Use a tiny function to tack tiny UUID's to end of LocalStorage keys instead of a seperate indexer #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of a seperate indexer
|
Could I get feedback on this I would love for it to get merged in, it took me a reasonable amount of time to pull this together. Right now I am looking for work also and this would be a big feather in my cap. I am aware that this is a big change and it may be better for it to be a separate adaptor but am happy to work with you on any changes you think are required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using LocalStorage keys like "storeadaptorname.key" and a seperate indexer to maintain order I have used a key in the form "storeadaptorname.key.UUID" where UUID is a small creation time orderable string.
This removes the requirement for a separate indexer and therefore should make the storage more reliable as writes will be more atomic.