-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable file path to data on bref-local with CDK #1627
Enable file path to data on bref-local with CDK #1627
Conversation
Hey, that sounds like a good idea. I'm not familiar with |
Great, I will work on the docs and update the PR in due course. Thanks |
Thanks! |
I have had another look at this and think it might actually be better to match the way we invoke locally with the way we would if using Serverless. Serverless CDK/TF If you think that is worth doing, I follow up with another PR. Thanks |
Sorry I'm missing what would be different with what you implemented? |
Apologies, I didn't explain very well above. In the current implementation, when we pass the When running Bref with Serverless, the handler file has the |
Oh yes that would be great indeed, in most PHP CLIs (artisan, Symfony Console) that's how it works. If you can do that without pulling in more dependencies that would be a very good improvement 👍 |
This change provides command line access to the
--path
flag where an application is built on AWS CDK rather than Serverless framework. This enables the passing of a path to a JSON file when runningvendor/bin/bref--local
instead of passing data as a string.If you agree with the premise of this change, I will also update the relevant documentation and include in the PR.