-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support secrets from AWS Secrets Manager #1514
Comments
We are currently printing env vars (fetching them from AWS Secrets Manager) in pipeline to file and including the env file in deployment. Not ideal, but works. Having direct support would be appreciated with possibility to change them without need for deployment, however, we faced an issue with SSH and OAuth keys being too big and exceeding Lambda's env var limit. |
Hi! Working on this feature is not at the top of my priorities at the moment (for lack of time), but I'm happy to talk about company sponsoring so that I can prioritize this development ❤️ Feel free to reach out at [email protected] |
Hi @mnapoli 👋 I can only imagine how time consuming it would be for you to look after Bref, as I said in my original message, if the idea of such feature was welcome I would be happy to work on a PR to avoid you having to do it, that's what open-source is for 😄 Based on the comment from @sladg here, and this issue on So here is a PR I've put together: brefphp/secrets-loader#4 Thanks again for responding, and looking forward to hearing from you 😉 |
Hey @natepage that looks awesome, thanks for the PR! I'll review that in more details ASAP |
Hi there!
Would like to know if the idea of extending
bref/secrets-loader
to support fetching secrets from AWS Secrets Manager would be welcome?If yes, would be happy to work on a PR 😄
The text was updated successfully, but these errors were encountered: