Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build #105

Closed
mnapoli opened this issue Dec 4, 2018 · 3 comments
Closed

Fix the build #105

mnapoli opened this issue Dec 4, 2018 · 3 comments

Comments

@mnapoli
Copy link
Member

mnapoli commented Dec 4, 2018

Since Symfony 4.2 was released the phpstan build is broken with these errors:

Parameter #1 $command of class Symfony\Component\Process\Process constructor expects array, string given.

See https://travis-ci.com/mnapoli/bref/jobs/162831081

Since I'm focused on the benchmarks and v0.3 that would be awesome if someone were to send a pull request to fix this. While I don't want to say this is easy I have to say this shouldn't be extra hard: the string parameter should be changed to an array (split each argument). A good way to get started contributing ;)

@incoming-th
Copy link
Contributor

I was working on that. Fixing phpstan is easy but other issues are appearing during phpunit.

I will make a PR for the fix in phpstan but build will still fail because of phpunit issues and are pretty weird ... at least for me for now.

@mnapoli
Copy link
Member Author

mnapoli commented Dec 5, 2018

👍 ok I wasn't expecting that, thanks anything that improves the situation is good.

@incoming-th
Copy link
Contributor

incoming-th commented Dec 5, 2018

I only focused on phpstan PR #108

I also added the phpunit errors if relevant for another issue into the PR.

@mnapoli mnapoli closed this as completed Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants