Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SQLite on both PHP 8.2 and 8.3 #187

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

GrahamCampbell
Copy link
Contributor

No description provided.

@@ -378,7 +378,8 @@ RUN make && make install
# SQLite
# Since PHP 7.4, libsqlite must be installed (https://github.com/php/php-src/blob/99b8e67615159fc600a615e1e97f2d1cf18f14cb/UPGRADING#L616-L619)
# PHP 8.4 requires SQLite 3.13.0 or higher because the build uses the
# `SQLITE_DBCONFIG_ENABLE_LOAD_EXTENSION` constant. The system version is 3.7.17.
# `SQLITE_DBCONFIG_ENABLE_LOAD_EXTENSION` constant. Moreover, Laravel 11
# requires SQLite 3.35.0 or higher. The system version is 3.7.17.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link on why Laravel requires a specific SQLite version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Laravel 11 also requires PHP 8.2 or higher, so it's not necessarily to backport this change to PHP 8.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

laravel/framework#48864 was the change that drove this btw.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I updated the documentation in #189

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrahamCampbell we have extended SQLite support to 3.26+ on Laravel 11.15: laravel/docs#9768

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for letting us know! The system version is 3.7 so we still need to compile sqlite manually, but it's good to know!

@mnapoli mnapoli merged commit ae6363e into brefphp:main Jul 22, 2024
6 checks passed
@GrahamCampbell GrahamCampbell deleted the upgrade-sqlite branch July 22, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants