Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Assembly Definitions to Appboy Plugin. #52

Closed
MartinGonzalez opened this issue Sep 2, 2019 · 9 comments
Closed

Add Assembly Definitions to Appboy Plugin. #52

MartinGonzalez opened this issue Sep 2, 2019 · 9 comments

Comments

@MartinGonzalez
Copy link

This would be really useful for those who use Asmdef in their project. I can create a pull request if you are in favor of this idea.

@Bucimis
Copy link
Collaborator

Bucimis commented Sep 6, 2019

@MartinGonzalez would people who don't use Asmdef be unaffected? Feel free to raise a pull request, we welcome open source contributions & incorporate them when appropriate.

@Bucimis
Copy link
Collaborator

Bucimis commented Jul 20, 2021

@MartinGonzalez is this still an issue for you? We haven't heard other customers ask for this but wanted to check in.

@starikcetin
Copy link

starikcetin commented May 4, 2022

@Bucimis Of course this is an issue! All UPM packages are required to have asmdef files, and when you don't put asmdef files in your code I can't consume them from my UPM pacakge and need to create asmdef files for your library dynamically!

People who don't use asmdefs can still use your code without changing anything as long as you leave "Auto Referenced" enabled in your asmdef files:

Specify whether the predefined assemblies should reference this Project assembly. When you disable the Auto Reference option, Unity does not automatically reference the assembly during compilation. This has no effect on whether Unity includes it in the build.

See here: https://docs.unity3d.com/Manual/class-AssemblyDefinitionImporter.html#general

@Bucimis
Copy link
Collaborator

Bucimis commented May 4, 2022

@starikcetin thanks for the additional context. We've added a roadmap item to investigate further and will let you know as we have updates

@starikcetin
Copy link

starikcetin commented Jul 8, 2022

Are there any updates yet? It has proved very annoying to work with Braze because of this issue. I can create a PR for you if you want.

@radixdev
Copy link
Collaborator

radixdev commented Jul 8, 2022

Hi @starikcetin ,

We do not have any more updates. However we would be very open to any ideas (or PR) about how you'd like a Braze Unity asm definition(s) organized. Would there be a single Asmdef for each platform? What would be the most straightforward way to go about testing our Asmdef works in a project?

@starikcetin
Copy link

starikcetin commented Jul 8, 2022

Hi @starikcetin ,

We do not have any more updates. However we would be very open to any ideas (or PR) about how you'd like a Braze Unity asm definition(s) organized. Would there be a single Asmdef for each platform? What would be the most straightforward way to go about testing our Asmdef works in a project?

Hello @radixdev

You don't need any platform-specificity. If it was working without asmdefs, it will work with asmdefs too. Asmdef files are only for C# source code, native plugins are not affected by asmdefs.

You need 1 asmdef for runtime code, and another one for editor code, that's it.

You should be able to continue using your existing tests, maybe with minor tweaks so that they can consume the new asmdef files.

I will try to prepare a PR soon.

@starikcetin
Copy link

@MartinGonzalez @Bucimis @radixdev
Created a PR that adds asmdef files: #94

@radixdev
Copy link
Collaborator

This has been released in version 3.8.1. Thank you @starikcetin and @MartinGonzalez for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants