-
Notifications
You must be signed in to change notification settings - Fork 41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ But we need the same fix in staging branch. We use diff branches for production and for staging.
travis is failing as well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not submit PR directly into master
Current branch:
staging branch(staging)
master branch(production)
You will have to submit PR to staging first and then after it is merged you use merge commit to open PR against master.
df2db70
to
39d7307
Compare
@darkdh OK great - updated 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Update deps with `npm audit fix`
Merge pull request #282 from brave/sync-fix-deps
Resolves this warning (found via
npm audit
):