Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checking reward endpoints if not opted into rewards #243

Closed
kjozwiak opened this issue Mar 4, 2021 · 1 comment
Closed

checking reward endpoints if not opted into rewards #243

kjozwiak opened this issue Mar 4, 2021 · 1 comment
Assignees
@kjozwiak
Labels
enhancement Greaselion

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Mar 4, 2021

Update our manual passes so we're checking/ensuring that reward endpoints are not being contact when visiting pages that rely on Greaselion if the user hasn't opted into rewards. This was fixed via brave/brave-browser#14307 but we need to make sure we don't regress or other calls sneak in.
@kjozwiak kjozwiak self-assigned this Mar 4, 2021
@kjozwiak kjozwiak mentioned this issue Mar 4, 2021
Merged
@kjozwiak
Copy link
Member Author

kjozwiak commented Apr 20, 2021 •
edited
Loading

Closing. This was fixed via #244 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kjozwiak kjozwiak

Labels
enhancement Greaselion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kjozwiak