This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Add Importer support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Sep 16, 2016
| 'libquery_parser.a', | ||
| 'liburl_formatter.a', | ||
| ], | ||
| 'linux': [ |
There was a problem hiding this comment.
have you checked these on linux and windows or are these a guess based on the mac libs?
There was a problem hiding this comment.
I've tested on linux, windows and mac before submitting PR.
|
I'll merge this after I finish updating to 53.0.2785.116 |
darkdh
added a commit
to brave/muon
that referenced
this pull request
Sep 19, 2016
requires brave/libchromiumcontent#3 Auditors: @bridiver, @bbondy, @bsclifton
darkdh
force-pushed
the
import-browser-data
branch
2 times, most recently
from
e116b6c to
da7cc7d
Compare
Auditors: @bridiver, @bbondy, @bsclifton
darkdh
force-pushed
the
import-browser-data
branch
from
da7cc7d to
899d62c
Compare
|
++ just waiting for a small update to #4 and I'll merge both and get the builds started |
bridiver
pushed a commit
to brave/muon
that referenced
this pull request
Sep 21, 2016
requires brave/libchromiumcontent#3 Auditors: @bridiver, @bbondy, @bsclifton
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors: @bridiver, @bbondy, @bsclifton