Check for glibc version instead of distro version

[wknapik]

Resolves #5 (enforce system requirements)
Resolves #24 (various improvements)
Resolves #9 (support for macOS)
Adds support for Manjaro

[fmarier]

This looks good to me, but before merging:

• Let's have @stoletheminerals review as well.
• Let's confirm that installing using cask on macOS will not interfere with auto-updates.

[wknapik]

@fmarier I assume we're still waiting for approval from @stoletheminerals?

[fmarier]

@wknapik Yes, are you done making all of the changes you wanted to make?

I'd like Artem to review since he's assigned to the sec review and we're not planning any other changes to the MVP script after this.

[wknapik]

Yes, are you done making all of the changes you wanted to make?

Yeah, I think so

We'll ask people internally to test before going public and maybe we'll make some adjustments then, in a new PR

[wknapik]

Actually, pushed one last change to the README

[wknapik]

And a few more ;]

[stoletheminerals]

lgtm! since it supports macos installation with brew, do we plan to add it to https://brave.com/download/? It seems macos doesn't have a dedicated landing page

[wknapik]

lgtm! since it supports macos installation with brew, do we plan to add it to https://brave.com/download/? It seems macos doesn't have a dedicated landing page

Do we want to promote that method of installation?

With the auto-updater on macOS, just downloading and double-clicking on a .dmg seems simple enough. No need to have users run commands in a terminal. But maybe I'm not seeing some upside?

For someone who has to do it frequently (like members our QA team), the script might end up being more convenient, but for the average user, I'm guessing not so much.

Let's see what feedback we get once this goes live.

[wknapik]

We could also extend support to windows via WSL, I think

[wknapik]

@fmarier please approve as code owner and we'll merge

[fmarier]

We could also extend support to windows via WSL, I think

It already works on WSL according to @bsclifton who tested an earlier version. WSL is basically just Ubuntu.

[wknapik]

It already works on WSL according to @bsclifton who tested an earlier version. WSL is basically just Ubuntu.

So that installs the Linux browser, which then runs under WSL, right?
I was thinking of installing the Windows version of the browser via WSL.
I haven't used WSL, so I don't know if that makes sense, but if it does, we could do that.

[fmarier]

I see. Yes, right now it would install the Linux version (.deb).

Good idea. Worthy of a new-distro issue in this repo. Could be a nice opportunity for someone in the community to volunteer a PR.

[wknapik]

Opened #36

[bsclifton]

It already works on WSL according to @bsclifton who tested an earlier version. WSL is basically just Ubuntu.

So that installs the Linux browser, which then runs under WSL, right? I was thinking of installing the Windows version of the browser via WSL. I haven't used WSL, so I don't know if that makes sense, but if it does, we could do that.

Yup- this installs the Linux version. When you open it, it'll open the app in a new window but it's the Linux version.

I'm not sure how you can interface with Windows from WSL; they have different file systems. There might be a compatibility layer, but I doubt you can just do an install (to Windows from WSL). I'd love to be wrong though