Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for 64 bit processors #2

Closed
fmarier opened this issue Sep 24, 2024 · 1 comment · Fixed by #18
Closed

Check for 64 bit processors #2

fmarier opened this issue Sep 24, 2024 · 1 comment · Fixed by #18
Labels
MVP

Comments

@fmarier
Copy link
Member

fmarier commented Sep 24, 2024

Run uname -i and only accept x86_64 and aarch64.
@fmarier fmarier added the MVP label Sep 28, 2024
@wknapik
Copy link
Collaborator

wknapik commented Oct 3, 2024 •
edited
Loading

man uname calls -i "non-portable". And indeed, on my system it just prints "unknown".

We should probably use uname -m.

I think x86_64, arm64 and aarch64 should suffice for now.

@wknapik wknapik mentioned this issue Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MVP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added an architecture check brave/install.sh
2 participants
@fmarier @wknapik