Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package-lock.json #19

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Update package-lock.json #19

merged 1 commit into from
Feb 8, 2019

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Feb 7, 2019 •
edited
Loading

Fix #18 hopefully by deleting node_modules and package-lock.json and re-running npm install

Test plan:
Make sure package-lock.json says lodash is 4.17.11

@diracdeltas
Update package-lock.json
59b1643 
Fix #18 hopefully

Test plan:
Make sure package-lock.json says lodash is 4.17.11
@diracdeltas diracdeltas requested a review from evq February 7, 2019 21:37
evq
evq approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@evq evq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regenerated locally, no diff & confirmed lodash version 👍

@diracdeltas diracdeltas merged commit 518d17d into master Feb 8, 2019
@bsclifton bsclifton deleted the fix/18 branch February 19, 2019 16:12
@bsclifton bsclifton mentioned this pull request Feb 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evq evq evq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diracdeltas @evq