This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Clear browser data #3051
Merged
Clear browser data #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auditors: @diracdeltas |
|
Going to merge this but please review and I'll do followups. |
| @@ -393,18 +392,17 @@ const init = (settingsState, args) => { | |||
| accelerator: 'Shift+CmdOrCtrl+Delete', | |||
| enabled: siteUtil.hasNoTagSites(appStore.getState().get('sites')), | |||
There was a problem hiding this comment.
I think the menu needs to be rebuilt when the first tagless site is added; otherwise this shows up as disabled even though i have visited some sites.
STR:
clear history
visit a site
open History menu, the 'clear history' item is disabled
There was a problem hiding this comment.
Actually I'll just simplify this to not disable the item, there is no need to disable the functionality even if it does no-op because already cleared. And disabling adds confusion for why it is disabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.Fix #2471