This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrose17
previously approved these changes
Jun 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most excellent!
Resolves brave#14351 Auditors: Test Plan:
NejcZdovc
force-pushed
the
fix/#14351-verified
branch
from
June 21, 2018 12:56
bbee6f1
to
351a5c4
Compare
mrose17
approved these changes
Jun 21, 2018
Checked the following:
Also found that verified twitch publishers are not displaying the verified check mark. |
bsclifton
added a commit
that referenced
this pull request
Jun 21, 2018
Fixes verfied check for YouTube
bsclifton
added a commit
that referenced
this pull request
Jun 21, 2018
Fixes verfied check for YouTube
mrose17
added a commit
that referenced
this pull request
Jun 21, 2018
NejcZdovc
pushed a commit
that referenced
this pull request
Jul 3, 2018
and fix test on setting UUID for reporting Cherry-pick one fix from the master branch! #14485 S/ads-goodbye/ads-user-trials-goodbye Track down macOS notification errors And *really* make sure the unique-identifier is defined… Revert label More debug
NejcZdovc
pushed a commit
that referenced
this pull request
Jul 5, 2018
and fix test on setting UUID for reporting Cherry-pick one fix from the master branch! #14485 S/ads-goodbye/ads-user-trials-goodbye Track down macOS notification errors And *really* make sure the unique-identifier is defined… Revert label More debug
ryanml
pushed a commit
to ryanml/browser-laptop
that referenced
this pull request
Jul 6, 2018
and fix test on setting UUID for reporting Cherry-pick one fix from the master branch! brave#14485 S/ads-goodbye/ads-user-trials-goodbye Track down macOS notification errors And *really* make sure the unique-identifier is defined… Revert label More debug
NejcZdovc
pushed a commit
that referenced
this pull request
Aug 10, 2018
and fix test on setting UUID for reporting Cherry-pick one fix from the master branch! #14485 S/ads-goodbye/ads-user-trials-goodbye Track down macOS notification errors And *really* make sure the unique-identifier is defined… Revert label More debug
NejcZdovc
pushed a commit
that referenced
this pull request
Aug 10, 2018
and fix test on setting UUID for reporting Cherry-pick one fix from the master branch! #14485 S/ads-goodbye/ads-user-trials-goodbye Track down macOS notification errors And *really* make sure the unique-identifier is defined… Revert label More debug
NejcZdovc
pushed a commit
that referenced
this pull request
Aug 10, 2018
and fix test on setting UUID for reporting Cherry-pick one fix from the master branch! #14485 S/ads-goodbye/ads-user-trials-goodbye Track down macOS notification errors And *really* make sure the unique-identifier is defined… Revert label More debug
NejcZdovc
pushed a commit
that referenced
this pull request
Aug 29, 2018
and fix test on setting UUID for reporting Cherry-pick one fix from the master branch! #14485 S/ads-goodbye/ads-user-trials-goodbye Track down macOS notification errors And *really* make sure the unique-identifier is defined… Revert label More debug
NejcZdovc
pushed a commit
that referenced
this pull request
Aug 31, 2018
and fix test on setting UUID for reporting Cherry-pick one fix from the master branch! #14485 S/ads-goodbye/ads-user-trials-goodbye Track down macOS notification errors And *really* make sure the unique-identifier is defined… Revert label More debug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14351
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests