Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes verfied check for YouTube #14485

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 21, 2018

Resolves #14351

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc self-assigned this Jun 21, 2018
mrose17
mrose17 previously approved these changes Jun 21, 2018
Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most excellent!

Resolves brave#14351

Auditors:

Test Plan:
@LaurenWags
Copy link
Member

Checked the following:

  • if a non-media publisher is verified, still displays the verified check mark
  • if a non-media publisher is not verified, still does not display verified check mark
  • if a YT channel is verified, now displays the verified check mark
  • if a YT channel is not verified, does not display verified check mark

Also found that verified twitch publishers are not displaying the verified check mark.

@bsclifton bsclifton added this to the 0.23.x (Beta Channel) milestone Jun 21, 2018
@bsclifton bsclifton merged commit 52838d0 into brave:master Jun 21, 2018
bsclifton added a commit that referenced this pull request Jun 21, 2018
bsclifton added a commit that referenced this pull request Jun 21, 2018
@bsclifton
Copy link
Member

master 52838d0
0.24.x febef50
0.23.x 2d69694

mrose17 added a commit that referenced this pull request Jun 21, 2018
NejcZdovc pushed a commit that referenced this pull request Jul 3, 2018
and fix test on setting UUID for reporting

Cherry-pick one fix from the master branch!

#14485

S/ads-goodbye/ads-user-trials-goodbye

Track down macOS notification errors

And *really* make sure the unique-identifier is defined…

Revert label

More debug
NejcZdovc pushed a commit that referenced this pull request Jul 5, 2018
and fix test on setting UUID for reporting

Cherry-pick one fix from the master branch!

#14485

S/ads-goodbye/ads-user-trials-goodbye

Track down macOS notification errors

And *really* make sure the unique-identifier is defined…

Revert label

More debug
ryanml pushed a commit to ryanml/browser-laptop that referenced this pull request Jul 6, 2018
and fix test on setting UUID for reporting

Cherry-pick one fix from the master branch!

brave#14485

S/ads-goodbye/ads-user-trials-goodbye

Track down macOS notification errors

And *really* make sure the unique-identifier is defined…

Revert label

More debug
NejcZdovc pushed a commit that referenced this pull request Aug 10, 2018
and fix test on setting UUID for reporting

Cherry-pick one fix from the master branch!

#14485

S/ads-goodbye/ads-user-trials-goodbye

Track down macOS notification errors

And *really* make sure the unique-identifier is defined…

Revert label

More debug
NejcZdovc pushed a commit that referenced this pull request Aug 10, 2018
and fix test on setting UUID for reporting

Cherry-pick one fix from the master branch!

#14485

S/ads-goodbye/ads-user-trials-goodbye

Track down macOS notification errors

And *really* make sure the unique-identifier is defined…

Revert label

More debug
NejcZdovc pushed a commit that referenced this pull request Aug 10, 2018
and fix test on setting UUID for reporting

Cherry-pick one fix from the master branch!

#14485

S/ads-goodbye/ads-user-trials-goodbye

Track down macOS notification errors

And *really* make sure the unique-identifier is defined…

Revert label

More debug
NejcZdovc pushed a commit that referenced this pull request Aug 29, 2018
and fix test on setting UUID for reporting

Cherry-pick one fix from the master branch!

#14485

S/ads-goodbye/ads-user-trials-goodbye

Track down macOS notification errors

And *really* make sure the unique-identifier is defined…

Revert label

More debug
NejcZdovc pushed a commit that referenced this pull request Aug 31, 2018
and fix test on setting UUID for reporting

Cherry-pick one fix from the master branch!

#14485

S/ads-goodbye/ads-user-trials-goodbye

Track down macOS notification errors

And *really* make sure the unique-identifier is defined…

Revert label

More debug
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants