Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmarking top tiles doesn't show default favicon #9568

Closed
srirambv opened this issue Jun 19, 2017 · 3 comments
Closed

Bookmarking top tiles doesn't show default favicon #9568

srirambv opened this issue Jun 19, 2017 · 3 comments
Assignees
@srirambv
Labels
feature/bookmarks misc/favicon priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.23.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jun 19, 2017 •
edited by luixxiul
Loading

Test plan

#13107 (comment)

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Bookmarking top tiles doens't show default favicon

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.17.3
    rev 02a7878
    Muon 4.0.3

  • Steps to reproduce:

    1. Clean install 0.17.3 and set bookmarks to show text and favicon
    2. Bookmark top tiles, no favicon/default favicon is shown
    3. Manually add a bookmark, default page icon is shown until page visit

  • Actual result:
    Bookmarking top tiles doens't show default favicon

  • Expected result:
    Should add the default favicon shown on toptiles

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Must be an existing issue on previous builds

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image

  • Any related issues:
    cc: @cezaraugusto
@bsclifton bsclifton changed the title Bookmarking top tiles doens't show default favicon Bookmarking top tiles doesn't show default favicon Jul 28, 2017
@bsclifton bsclifton added priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). and removed priority/low (deprecated) labels Nov 22, 2017
@bsclifton bsclifton added this to the Backlog (Prioritized) milestone Nov 22, 2017
@sergio-rojasa
Copy link

I would like to work on this issue.

@srirambv srirambv self-assigned this Feb 10, 2018
@srirambv
Copy link
Collaborator Author

@sergiorojasa self assigned for you to work on it. Please open up a PR with the fix

@sergio-rojasa sergio-rojasa mentioned this issue Feb 12, 2018
Merged
10 tasks
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), 0.23.x (Nightly Channel) Feb 12, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator Author

srirambv commented Jun 14, 2018 •
edited by LaurenWags
Loading

Verified on Windows x64 using

  • 0.23.8 06c657b
  • muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified with macOS 10.12.6 using

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

This was referenced Jun 19, 2018
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jun 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@srirambv srirambv

Labels
feature/bookmarks misc/favicon priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
7 participants
@kjozwiak @luixxiul @bsclifton @srirambv @sergio-rojasa @LaurenWags @btlechowski