Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Feature to Customize Proxy Settings / Make use of OS Proxy Settings #770

Closed
weems opened this issue Feb 15, 2016 · 16 comments
Closed

Feature to Customize Proxy Settings / Make use of OS Proxy Settings #770

weems opened this issue Feb 15, 2016 · 16 comments
Assignees
Labels
hackathon Legacy label for a hackaton.

Comments

@weems
Copy link

weems commented Feb 15, 2016

Request from user (Support) that we offer a Proxy Server to be used, whether that is set within Brave or whether we use the OS Proxy Server which has just been specified.

@Aphin1ty
Copy link

I am unable to use the browser in my environment as it requires a proxy. I have only tested the OS X version but it doesn't support my OS proxy settings and there is no way (that I can find) to define them in the browser itself.

@ajg-B
Copy link

ajg-B commented Feb 26, 2016

Likewise.
Any development to make Brave work in firewalled environments?

@bbondy
Copy link
Member

bbondy commented Feb 26, 2016

This is planned we just haven't gotten to it yet

@diracdeltas
Copy link
Member

diracdeltas commented Jun 3, 2016

@flyer0101 @ajg-B Brave uses my OS X system proxy settings afaict. could you try again with the latest release? if not, what are your proxy settings?

@diracdeltas diracdeltas self-assigned this Jun 3, 2016
@christophershirk
Copy link

@diracdeltas FWIW, latest Brave release works for me on OS X w/ SOCKS5 proxy in system preferences, except for 'Check for updates' (#1230). Brave: 0.10.0, Electron: 0.37.8, libchromiumcontent: 50.0.2661.102, V8: 5.0.71.48, Node.js: 5.10.0, Update channel: dev

@diracdeltas
Copy link
Member

@zeroshirts excellent catch; turns out the updater uses Node's request stack instead of Chromium's so it bypasses system proxy settings. I'm going to close this since we do use OS proxy settings most of the time and open more specific issues.

@danwdart
Copy link

I see this issue still exists... If I set my proxy in KDE using local/global modes, it still doesn't affect brave... is this something that can be fixed?
(Ubuntu 16.04)
And what is the workaround for now?

@diracdeltas
Copy link
Member

@dandart are you seeing no requests go through the proxy? or only some requests?

@danwdart
Copy link

None at all, I refresh a show-my-IP website and it shows my home IP.

@diracdeltas
Copy link
Member

what happens in Chrome?

@danwdart
Copy link

Chrom(e|ium) obeys the settings.

@diracdeltas
Copy link
Member

that's definitely weird because brave uses the same network stack as chromium for most requests

@danwdart
Copy link

Even on Ubuntu?

@danwdart
Copy link

Then again it could be the caching issue I was having... when pages are refreshed new content isn't subbed in. I'll test again later on

@srirambv
Copy link
Collaborator

+1 from support

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hackathon Legacy label for a hackaton.
Projects
None yet
Development

No branches or pull requests

8 participants