Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

View page source should respect private windows #4077

Merged
merged 1 commit into from
Sep 17, 2016
Merged

View page source should respect private windows #4077

merged 1 commit into from
Sep 17, 2016

Conversation

Sh1d0w
Copy link

@Sh1d0w Sh1d0w commented Sep 17, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #4069

@bbondy

Test Plan:
Open a private tab and load any website
Right click on the page and choose Show Source

Fixes #4069

@bbondy

Test Plan:
Open a private tab and load any website
Right click on the page and choose Show Source
@Sh1d0w Sh1d0w added the bug label Sep 17, 2016
@Sh1d0w Sh1d0w added this to the 0.12.2dev milestone Sep 17, 2016
@Sh1d0w Sh1d0w self-assigned this Sep 17, 2016
@bbondy
Copy link
Member

bbondy commented Sep 17, 2016

nice catch, thanks.

@bbondy bbondy merged commit 2384bb6 into brave:master Sep 17, 2016
@da2x
Copy link
Contributor

da2x commented Sep 17, 2016

Please also test reloading the tab with the source … .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants