Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Horizontal Scroll bar appears with just one entry in Brave Payments #3792

Closed
srirambv opened this issue Sep 7, 2016 · 5 comments
Closed
Assignees
Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone

Comments

@srirambv
Copy link
Collaborator

srirambv commented Sep 7, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Horizontal Scroll bar appears with just one entry in Brave Payments

Expected behavior:
Horizontal scroll bar should appear when the list goes beyond the frame

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64, OpenSuse Tumbleweed
  • Brave Version:
    0.12.0
  • Steps to reproduce:
    1. Enable Brave payments in about:preferences#payments
    2. Create wallet and visit any site to get listed under payments
    3. Horizontal scroll bars appear even if there is one entry
  • Screenshot if needed:
    image
  • Any related issues:
@srirambv srirambv added the design A design change, especially one which needs input from the design team. label Sep 7, 2016
@bradleyrichter
Copy link
Contributor

@srirambv Have you tried rotating your laptop 90 degrees? Doh! ; )

@bradleyrichter
Copy link
Contributor

@diracdeltas Are we just missing some CSS for auto-scroll bars?

@diracdeltas
Copy link
Member

cc @jkup, i think this just uses

 height: ~"-webkit-calc(100vh - 300px)";
 overflow-y: scroll;

which is fine on osx but apparently causes unnecessary scrollbars on linux/win

@jkup jkup self-assigned this Sep 7, 2016
@jkup
Copy link
Contributor

jkup commented Sep 7, 2016

cool I'll check it out asap

@bbondy
Copy link
Member

bbondy commented Sep 8, 2016

a value of scroll isn't fine for macOS either sometimes depending on your scrollbar setting. It should just be a simple scroll -> auto fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Development

No branches or pull requests

10 participants