Add the ability to open up non-Tor private tabs #14459

bbondy · 2018-06-19T19:22:43Z

Description

Currently there are 2 modes:
i) Use all private tabs as Tor private tabs
ii) Use all private tabs as normal private tabs

Tor private tabs is an awesome feature, but they are slow. So the choice between them seamlessly is important for us to deliver this feature correctly without angering our user base.

Having an all or nothing private tab option covers the use case that a privacy conscious user wants to be fully private.

But there are other use cases that people use private tabs for, the main one being a user just doesn't want cookies saved for a 1 time login. For example logging into gmail with 1 time access when you don't want cookies saved.

Others include you don't want history stored, but you are ok that it's not fully private, but still want fast browsing speed. A lot of our user base are advanced users so we need to still keep them in mind.

Currently you have to switch the global option on or off.

There was also talk about removing the Tor indicator. That needs to be there as a reminder of why a tab is slow.

Steps to Reproduce

For each case there should be separate items for private tabs and for Tor private tabs.

Case 1:

Add an option when right clicking on a link:

Case 2:

Add an option in the hamburger menu:

Case 3:

Add an option to the new tab drop down ~~(sorry no screenshot, but just click and hold the new tab button)~~

Actual result:

Only 1 private tab option is available.

Expected result:

Options for both private tabs and Tor private tabs should be available.
Please also fail this testing if there is no Tor indicator for the Tor tabs.

Reproduces how often:

Always.

Brave Version

0.22.810

about:brave info:

Brave: 0.22.810
V8: 6.7.288.43
rev: 8f30eeb
Muon: 7.0.6
OS Release: 17.4.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.71

Reproducible on current live release:

Only in Tor builds (Beta channel).

Additional Information

None.

The text was updated successfully, but these errors were encountered:

diracdeltas · 2018-06-19T20:50:27Z

needs input from @davidtemkin

fix #14459 test plan: 1. every menu that says 'open in new private tab' should also have an item that says 'open in new tor tab' 2. opening in a new tor tab should show the tor indicator on 3. opening in a new private tab should show the tor indicator off 4. ddg is enabled by default for now but can be turned off 5. cmd+click should open in the same type as the current tab 6. turning the tor switch on/off in a new tab should work 7. in a tor tab, right-click should show 'open in new tor tab' first

riastradh-brave · 2018-06-20T16:13:50Z

in principle this is fine by me. I'm taking a closer look and I will try to give this a test soon.

diracdeltas · 2018-06-20T19:10:08Z

after some discussion on what to do WRT the DDG switch, we decided:

private tabs with tor will have DDG enabled by default regardless of the setting in regular private tabs, and no switch is shown on about:newtab for private tabs with tor
there will be a pref in about:preferences to override this behavior (AKA use the normal default search engine)

Test Plan: Check that the DDG switch in regular private tabs doesn't affect tor tabs and that the DDG switch in about:preferences for Tor tabs doesn't affect regular private tabs. Also check that DDG is default on for tor tabs.

fix #14459 test plan: 1. every menu that says 'open in new private tab' should also have an item that says 'open in new tor tab' 2. opening in a new tor tab should show the tor indicator on 3. opening in a new private tab should show the tor indicator off 4. ddg is enabled by default for now but can be turned off 5. cmd+click should open in the same type as the current tab 6. turning the tor switch on/off in a new tab should work 7. in a tor tab, right-click should show 'open in new tor tab' first

Test Plan: Check that the DDG switch in regular private tabs doesn't affect tor tabs and that the DDG switch in about:preferences for Tor tabs doesn't affect regular private tabs. Also check that DDG is default on for tor tabs.

fix #14459 test plan: 1. every menu that says 'open in new private tab' should also have an item that says 'open in new tor tab' 2. opening in a new tor tab should show the tor indicator on 3. opening in a new private tab should show the tor indicator off 4. ddg is enabled by default for now but can be turned off 5. cmd+click should open in the same type as the current tab 6. turning the tor switch on/off in a new tab should work 7. in a tor tab, right-click should show 'open in new tor tab' first

Test Plan: Check that the DDG switch in regular private tabs doesn't affect tor tabs and that the DDG switch in about:preferences for Tor tabs doesn't affect regular private tabs. Also check that DDG is default on for tor tabs.

diracdeltas · 2018-06-21T18:42:11Z

fixed by #14467

fix #14459 test plan: 1. every menu that says 'open in new private tab' should also have an item that says 'open in new tor tab' 2. opening in a new tor tab should show the tor indicator on 3. opening in a new private tab should show the tor indicator off 4. ddg is enabled by default for now but can be turned off 5. cmd+click should open in the same type as the current tab 6. turning the tor switch on/off in a new tab should work 7. in a tor tab, right-click should show 'open in new tor tab' first

Test Plan: Check that the DDG switch in regular private tabs doesn't affect tor tabs and that the DDG switch in about:preferences for Tor tabs doesn't affect regular private tabs. Also check that DDG is default on for tor tabs.

LaurenWags · 2018-06-22T18:07:08Z

Verified with macOS 10.12.6 using

0.23.14 f4da855
Muon 7.1.1
libchromiumcontent 67.0.3396.87
verified test steps and Add the ability to open up non-Tor private tabs #14459 (comment)

Verified with Windows 10 x64 using

0.23.14 f4da855
Muon 7.1.1
libchromiumcontent 67.0.3396.87

Verified on Ubuntu 17.10 x64

0.23.16 - 2042c45
Muon - 7.1.1
libchromiumcontent - 67.0.3396.87