Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

add tab UI indicator of whether a private tab is running Tor #14175

Closed
diracdeltas opened this issue May 18, 2018 · 3 comments
Closed

add tab UI indicator of whether a private tab is running Tor #14175

diracdeltas opened this issue May 18, 2018 · 3 comments
Assignees
Labels
design A design change, especially one which needs input from the design team. feature/tor QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/exclude

Comments

@diracdeltas
Copy link
Member

diracdeltas commented May 18, 2018

If a user opens a bunch of private tabs and turns the tor switch off in some of them, it gets confusing to remember which tabs were Tor ones and which ones weren't. We should add some iconography to the tab to show that it's a Tor tab (similar to the icon for private tab and session tabs).

cc @bradleyrichter @rossmoody for an icon we can use

TEST PLAN:

  1. open tor tab
  2. you should see a 'Tor' icon in the tab
  3. the 'Tor' icon should not appear on any non-Tor tabs
@diracdeltas diracdeltas added this to the 0.23.x (Developer Channel) milestone May 18, 2018
@diracdeltas diracdeltas self-assigned this May 18, 2018
diracdeltas added a commit that referenced this issue May 22, 2018
@alexwykoff alexwykoff added the design A design change, especially one which needs input from the design team. label May 22, 2018
@alexwykoff
Copy link
Contributor

We'll need a bit of a tighter icon for use in the tab control @rossmoody

diracdeltas added a commit that referenced this issue May 22, 2018
@diracdeltas
Copy link
Member Author

fixed by 6a5e8a9 for now

@srirambv
Copy link
Collaborator

srirambv commented Jun 21, 2018

Verified on Windows 10 x64 using

  • 0.23.12 - 88f6f07
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified on macOS 10.13.4 x64 using the following build:

  • 0.23.12 88f6f07
  • muon: 7.1.1
  • libchromiumcontent: 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.14 - f4da855
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

bsclifton pushed a commit that referenced this issue Jun 22, 2018
diracdeltas added a commit that referenced this issue Jun 22, 2018
bsclifton pushed a commit that referenced this issue Jun 23, 2018
bsclifton pushed a commit that referenced this issue Jun 25, 2018
bsclifton pushed a commit that referenced this issue Jun 26, 2018
bsclifton pushed a commit that referenced this issue Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/tor QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/exclude
Projects
None yet
Development

No branches or pull requests

7 participants