Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Connection log pops up in a console window when opening a private tab #14029

Closed
srirambv opened this issue May 4, 2018 · 6 comments
Closed

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 4, 2018

Description

Connection log pops up in a console window when opening a private tab

Steps to Reproduce

  1. Install 0.23.2 developer build
  2. Open a new private tab
  3. Tor connection log pops up as a console window
  4. Close the console and visit any site in Private tab
  5. Console pops up again

Actual result:
image

Expected result:
Should not show connection info on console

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.23.2
V8 6.6.346.26
rev c09cbf6
Muon 6.1.0
OS Release 10.0.16299
Update Channel Developer
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 66.0.3359.139

Reproducible on current live release:
N/A

Additional Information

cc: @riastradh-brave @diracdeltas @jumde

@srirambv srirambv added bug feature/tor 0.23.x issue first seen in 0.23.x labels May 4, 2018
@srirambv srirambv added this to the 0.23.x (Developer Channel) milestone May 4, 2018
@darkdh darkdh self-assigned this May 6, 2018
@diracdeltas
Copy link
Member

@darkdh in fixing this, can we just write Tor process logs to disk on all platforms? that would help with debugging.

@darkdh
Copy link
Member

darkdh commented May 8, 2018

this popup shown is not because we launch tor. it is utility process, I'm working on this.

and I am all for writing tor log into a disk file on all platforms.

@darkdh
Copy link
Member

darkdh commented May 9, 2018

fixed by brave/muon@6d6cda7 which will be available in muon 6.1.1

@btlechowski
Copy link
Contributor

btlechowski commented Jun 13, 2018

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Windows 10 x64
• 0.23.8 06c657b
• Muon 6.1.5
• libchromiumcontent 66.0.3359.181

@srirambv
Copy link
Collaborator Author

srirambv commented Jun 21, 2018

Verified on Windows 10 x64 using

  • 0.23.12 - 88f6f07
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified on macOS 10.13.4 x64 using the following build:

  • 0.23.12 88f6f07
  • muon: 7.1.1
  • libchromiumcontent: 67.0.3396.87

@kjozwiak
Copy link
Member

kjozwiak commented Jun 22, 2018

@srirambv @GeetaSarvadnya we'll need to retest this against Windows once 0.23.14 is released. Clearing the tags and removed the the check from #14495.

@kjozwiak
Verified on Windows 10 x64
• 0.23.14 f4da855
• Muon 7.1.1
• libchromiumcontent: 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.14 - f4da855
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.