Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adblock Custom Filters Do Not Work #12308

Closed
Jozer99 opened this issue Dec 17, 2017 · 9 comments
Closed

Adblock Custom Filters Do Not Work #12308

Jozer99 opened this issue Dec 17, 2017 · 9 comments

Comments

@Jozer99
Copy link

Jozer99 commented Dec 17, 2017

Description

Adblock custom filters on about:adblock do not work. This bug seems to have been reported and closed multiple times before but still exists.

Steps to Reproduce

Simple example:

  1. Go to website www.nytimes.com
  2. Verify that NY Times logo image is contained in div class "nyt-logo"
  3. Go to about:adblock and scroll to custom filters
  4. Create custom filter "##.nyt-logo"
  5. Refresh www.nytimes.com

Actual result:
The NY Times logo is still visible.

Expected result:
The NY Times logo should have disappeared from the NY Times page. Note that this is just an example, I don't actually want to block the NY Times logo. Tested on Chrome with uBlock Origin and got the correct behavior.

Reproduces how often:
100% of the custom filters I have tried have zero effect, including simple ones such as the example described above.

Brave Version

about:brave info:

Name Version
Brave 0.19.116
rev 139c117
Muon 4.5.16
libchromiumcontent 62.0.3202.94
V8 6.2.414.42
Node.js 7.9.0
Update Channel Release
OS Platform Microsoft Windows
OS Release 10.0.15063
OS Architecture x64

Reproducible on current live release:

Additional Information

@Alino
Copy link

Alino commented Feb 8, 2018

I confirm this on Mac.

I want to block the annoying ads at the end of a youtube video by adding this rule

www.youtube.com##.ytp-ce-element

but it doesn't work

@Jozer99
Copy link
Author

Jozer99 commented Feb 16, 2018

Is this issue ever going to be addressed? For a browser that advertises its privacy features, having a non-functional content blocker seems like a big deal.

@lembitk
Copy link

lembitk commented Mar 14, 2018

Confirming this on Win 10 x64, Brave v0.21.18 (rev 580be78; current live release as of 15.03.2018).

Description

Custom filters in about:adblock do not work.

Steps to Reproduce

  1. Go to Spotify web player with shields up.
    1. Click "Play" on any music playlist/collection.
    2. Verify that there will be no audio playback/streaming.
  2. Go to about:adblock.
    1. Add @@audio-fa.scdn.co custom filter.

Actual result:

As the host audio-fa.scdn.co still gets blocked, audio playback/streaming is not possible with shields up.

Expected result:

The custom adblock filter @@audio-fa.scdn.co (and/or @@scdn.co/audio) should allow audio streaming from Spotify's CDN.

Additional Information

As I also think this is a rather big deal, taking the liberty to /cc @lukemulks. Thanks.

@bsclifton bsclifton added this to the Triage Backlog milestone Mar 18, 2018
@Alino
Copy link

Alino commented Jul 18, 2018

Why was this moved to Triage Backlog? I am afraid it will take years to fix this if this is not prioritised. There must be a way to add custom ad-block filters, especially now, when Brave native ad-block is not efficient enough and ignores many ads and keeps them displayed.
Please reconsider the priority for this issue, because even an ad-block chrome extension gives their users the opportunity to add custom filters. If an extension can do this, why a whole browser focused on ad-blocking can't ?

@notDavid
Copy link

If this functionality doesn't work, please remove the custom filter from the about:adblock page.

This just wastes peoples time, trying to figure out why it isn't working...

@bsclifton
Copy link
Member

@bbondy @kjozwiak @srirambv @LaurenWags does the custom filter functionality work?

@bsclifton bsclifton added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Jul 22, 2018
@mreza73
Copy link

mreza73 commented Jul 25, 2018

Confirming this on mac os 10.13.5 brave 0.23.39
custom filer doesn't work

@mitchwagner
Copy link

Custom element filters (###hot-network-question for Stack Exchange) do not seem to work for me. I'm using Brave 0.23.39, macOS 10.14 Beta

@bsclifton bsclifton removed the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Oct 1, 2018
@bsclifton
Copy link
Member

Closing in favor of brave/brave-browser#403

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants