Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger optimisations and cleanup #11210

Closed
6 of 16 tasks
NejcZdovc opened this issue Sep 29, 2017 · 1 comment
Closed
6 of 16 tasks

Ledger optimisations and cleanup #11210

NejcZdovc opened this issue Sep 29, 2017 · 1 comment
Assignees
@bsclifton @NejcZdovc
Labels
feature/rewards initiative/bat-payments project-tracking refactoring

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Sep 29, 2017 •
edited
Loading

Description

  • Move remaining functions from regular data to immutable
  • Add back flag for payments page in browser/tabs.js
  • Check why ledger page is enabled for a split second, before it's disabled while creating wallet Ledger is shown as enabled for a split second #11387
  • Remove location item from pageData->locations when tab is closed (pages that have this tabID)
  • Clear pageData when browser is closed
  • Check if we can clear windows in synopsis publishers as well?
  • Add unit tests
    • app/browser/api/ledger.js
    • app/browser/reducers/ledgerReducer.js
    • app/browser/reducers/pageDataReducer.js
    • app/browser/reducers/siteSettingsReducer.js
    • app/common/lib/ledgerUtil.js
    • app/common/lib/pageDataUtil.js
    • app/common/state/ledgerState.js
    • app/common/state/pageDataState.js
    • app/common/state/siteSettingsState.js
@NejcZdovc NejcZdovc added this to the 0.19.x (Beta Channel) milestone Sep 29, 2017
@NejcZdovc NejcZdovc self-assigned this Sep 29, 2017
@NejcZdovc NejcZdovc mentioned this issue Sep 29, 2017
Closed
@NejcZdovc NejcZdovc modified the milestones: 0.19.x (Beta Channel), 0.19.x Release 2 (Beta Channel) Oct 10, 2017
@NejcZdovc NejcZdovc added the Epic label Oct 24, 2017
@NejcZdovc NejcZdovc removed this from the 0.19.x Hotfix 6 (Release channel) milestone Nov 13, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton
Copy link
Member

Closing - we've made lots of great progress in this area. For more specific tracking, check out the GitHub project that @NejcZdovc put together for Brave Payments:
https://github.com/brave/browser-laptop/projects/16#card-6746244

@bsclifton bsclifton removed this from the Triage Backlog milestone Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

@NejcZdovc NejcZdovc

Labels
feature/rewards initiative/bat-payments project-tracking refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbondy @bsclifton @NejcZdovc