Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
exclude https everywhere on gq.com
Browse files Browse the repository at this point in the history 
fix #4366

Auditors: @bbondy

Test Plan:
1. rm httpse.json from your user data folder
2. select 'clear cache' from history menu
3. restart brave, go to gq.com. it should not redirect to https.
  • Loading branch information
@diracdeltas
diracdeltas committed Sep 28, 2016
1 parent d19ce40 commit 7516f02
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion preload-httpse.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ var exclusions = {
'Vodafone.ie.xml': 'breaks pagination on http://shop.vodafone.ie/shop/phonesAndPlans/phonesAndPlansHome.jsp?subPage=phones&planFilter=onAccount',
'IDownloadBlog.xml': 'breaks http://www.idownloadblog.com/',
'EBay_static.com.xml': 'breaks suggested product image previews',
'Cisco.xml': 'breaks http://www.cisco.com/c/m/en_us/training-events/events-webinars/techwise-tv/listings.html'
'Cisco.xml': 'breaks http://www.cisco.com/c/m/en_us/training-events/events-webinars/techwise-tv/listings.html',
'GQ.xml': 'mixed content on gq.com'
}

var rulesets = JSON.parse(fs.readFileSync('rulesets.json', 'utf8'))
Expand Down

3 comments on commit 7516f02

@bridiver
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to push a file for GQ.xml? Starting with this commit the tests don't even run

@diracdeltas
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bridiver weird, i'm not sure why. i pushed the rulesets to S3 and confirmed that they were downloaded by a fresh instance of Brave.

@bridiver
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't think this is related, just a coincidence

Please sign in to comment.