From cb5baf61dfb304f6215fbe81839895c92b796a1c Mon Sep 17 00:00:00 2001 From: Terry Mancey Date: Fri, 24 Sep 2021 16:09:25 -0500 Subject: [PATCH] Fallback to custom ad notifications on Windows and Android if native notifications are disabled --- seed/seed.json | 78 ++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 69 insertions(+), 9 deletions(-) diff --git a/seed/seed.json b/seed/seed.json index f5971400..1302a42b 100644 --- a/seed/seed.json +++ b/seed/seed.json @@ -547,10 +547,6 @@ "name": "CustomAdNotificationPositionedBottomRightOffsetToTheLeftOfSystemNotifications", "probability_weight": 30, "parameters": [ - { - "name": "can_fallback_to_custom_notifications", - "value": "true" - }, { "name": "ad_notification_normalized_display_coordinate_x", "value": "1.0" @@ -575,6 +571,35 @@ { "name": "CustomAdNotificationDefaultPosition", "probability_weight": 30, + "feature_association": { + "enable_feature": ["CustomAdNotifications"] + } + }, + { + "name": "Disabled", + "probability_weight": 0, + "feature_association": { + "disable_feature": ["CustomAdNotifications"] + } + }, + { + "name": "Default", + "probability_weight": 40 + } + ], + "filter": { + "min_version": "92.1.30.19", + "min_os_version": "10.0.17134.*", + "channel": ["BETA", "NIGHTLY"], + "platform": ["WINDOWS"] + } + }, + { + "name": "AdNotificationsWindowsStudy", + "experiments": [ + { + "name": "Enabled", + "probability_weight": 100, "parameters": [ { "name": "can_fallback_to_custom_notifications", @@ -582,25 +607,25 @@ } ], "feature_association": { - "enable_feature": ["CustomAdNotifications"] + "enable_feature": ["AdNotifications"] } }, { "name": "Disabled", "probability_weight": 0, "feature_association": { - "disable_feature": ["CustomAdNotifications"] + "disable_feature": ["AdNotifications"] } }, { "name": "Default", - "probability_weight": 40 + "probability_weight": 0 } ], "filter": { - "min_version": "92.1.30.19", + "min_version": "94.1.30.87", "min_os_version": "10.0.17134.*", - "channel": ["BETA", "NIGHTLY"], + "channel": ["RELEASE", "BETA", "NIGHTLY"], "platform": ["WINDOWS"] } }, @@ -773,6 +798,41 @@ "platform": ["ANDROID"] } }, + { + "name": "AdNotificationsAndroidStudy", + "experiments": [ + { + "name": "Enabled", + "probability_weight": 100, + "parameters": [ + { + "name": "can_fallback_to_custom_notifications", + "value": "true" + } + ], + "feature_association": { + "enable_feature": ["AdNotifications"] + } + }, + { + "name": "Disabled", + "probability_weight": 0, + "feature_association": { + "disable_feature": ["AdNotifications"] + } + }, + { + "name": "Default", + "probability_weight": 0 + } + ], + "filter": { + "min_version": "94.1.30.87", + "min_os_version": "8.*", + "channel": ["RELEASE", "BETA", "NIGHTLY"], + "platform": ["ANDROID"] + } + }, { "name": "BraveAds.ShowCustomAdNotificationOnAndroidStudy", "experiments": [