Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Large SVGs in Rewards should be external asset #267

Open
petemill opened this issue Nov 5, 2018 · 0 comments
Open

Large SVGs in Rewards should be external asset #267

petemill opened this issue Nov 5, 2018 · 0 comments

Comments

@petemill
Copy link
Member

petemill commented Nov 5, 2018

There are some large ~50kb assets that are included in the bundle. These would benefit from being external assets to consuming bundle sizes (especially valid on Android).

Inline SVGs are very useful when they are component-like, or for some other reason need to be styled with CSS. These assets seem like graphics and therefore do not need to be included. If they did, then I would suggest using import() or React.lazy() syntax so that they are contained in a different JS file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants