Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty format sign cancel request message on iOS #882

Closed
srirambv opened this issue May 4, 2023 · 3 comments
Closed

Pretty format sign cancel request message on iOS #882

srirambv opened this issue May 4, 2023 · 3 comments
Labels
iOS mobile ui wallet-support web3

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 4, 2023 •
edited
Loading

Description

Pretty format sign cancel request message on iOS

Steps

  1. Connect wallet to join Web3 call
  2. Cancel the sign message request
  3. Shows actual error message rather than Sign request cancelled

Actual Result

Cancel.Sign.message.MP4

Expected Result

Pretty formatted Sign request cancelled message when a user cancels the sign message
@srirambv srirambv added bug Something isn't working web3 iOS labels May 4, 2023
@StephenHeaps StephenHeaps mentioned this issue May 4, 2023
Closed
@StephenHeaps
Copy link

I can't assign myself this issue, but this should be resolved on iOS-end with brave/brave-ios#7392. Targeting v1.51.

@mrose17 mrose17 added ui wallet-support mobile and removed bug Something isn't working labels May 4, 2023
@mrose17
Copy link
Member

mrose17 commented May 4, 2023

cc: @HEagle18

I can't assign myself this issue, but this should be resolved on iOS-end with brave/brave-ios#7392. Targeting v1.51.

@StephenHeaps - thanks!

@srirambv
Copy link
Collaborator Author

srirambv commented May 8, 2023

This is fixed and verified as part of brave/brave-ios#7392 (comment)

@srirambv srirambv closed this as completed May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
iOS mobile ui wallet-support web3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrose17 @StephenHeaps @srirambv