From fc7bb25206ac44dc31e395cef2fdad40527abf45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Tue, 3 Oct 2023 17:58:44 +0200 Subject: [PATCH 01/13] [test] Github actions explicit iOS 17.0 set. --- fastlane/Fastfile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 276c198f752..349cddecf9b 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -37,8 +37,9 @@ platform :ios do run_tests( project: "App/Client.xcodeproj", scheme: "Debug", - device: "iPhone 14 (16.4)", + device: "iPhone 14 (17.0)", code_coverage: true, + ensure_devices_found: true, skip_testing: [ "CertificateUtilitiesTests/CertificatePinningTest/testSelfSignedRootAllowed", "CertificateUtilitiesTests/CertificatePinningTest/testSelfSignedRootAllowed2", @@ -71,8 +72,9 @@ platform :ios do run_tests( project: "App/Client.xcodeproj", scheme: "Debug", - device: "iPad (10th generation) (16.4)", + device: "iPad (10th generation) (17.0)", code_coverage: true, + ensure_devices_found: true, skip_testing: [ "ClientTests/UserAgentTests" ], From ebec87c4ca2948bf203120dc160a2edeef941b64 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Tue, 3 Oct 2023 19:00:13 +0200 Subject: [PATCH 02/13] test failure --- fastlane/Fastfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 349cddecf9b..6dbee8173d9 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -37,7 +37,7 @@ platform :ios do run_tests( project: "App/Client.xcodeproj", scheme: "Debug", - device: "iPhone 14 (17.0)", + device: "iPhone 14 (17.4)", code_coverage: true, ensure_devices_found: true, skip_testing: [ @@ -72,7 +72,7 @@ platform :ios do run_tests( project: "App/Client.xcodeproj", scheme: "Debug", - device: "iPad (10th generation) (17.0)", + device: "iPad (10th generation) (17.4)", code_coverage: true, ensure_devices_found: true, skip_testing: [ From e5d9687531bd6a962d3014b9cc74a657ac38f7b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Tue, 3 Oct 2023 19:11:13 +0200 Subject: [PATCH 03/13] Revert "test failure" This reverts commit ebec87c4ca2948bf203120dc160a2edeef941b64. --- fastlane/Fastfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 6dbee8173d9..349cddecf9b 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -37,7 +37,7 @@ platform :ios do run_tests( project: "App/Client.xcodeproj", scheme: "Debug", - device: "iPhone 14 (17.4)", + device: "iPhone 14 (17.0)", code_coverage: true, ensure_devices_found: true, skip_testing: [ @@ -72,7 +72,7 @@ platform :ios do run_tests( project: "App/Client.xcodeproj", scheme: "Debug", - device: "iPad (10th generation) (17.4)", + device: "iPad (10th generation) (17.0)", code_coverage: true, ensure_devices_found: true, skip_testing: [ From fff516c27527e232f56c1104a72f2346aeb71b32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Tue, 3 Oct 2023 20:20:06 +0200 Subject: [PATCH 04/13] [test] New job to test latest OS --- .github/workflows/build_and_test.yml | 52 ++++++++++++++++------------ fastlane/Fastfile | 11 ++++-- 2 files changed, 39 insertions(+), 24 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index c7b7e9e4934..fe337f92f34 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -7,35 +7,43 @@ on: - beta pull_request: +defaults: + runs-on: macOS-13 + env: + XCODE_VERSION: "14.3.1" + steps: + - name: Select XCode + run: sudo xcode-select --switch /Applications/Xcode_${{ env.XCODE_VERSION }}.app + - name: Checkout + uses: actions/checkout@v3 + - name: Update node + uses: actions/setup-node@v3 + with: + node-version: '18.x' + - uses: actions/cache@v3 + with: + path: ~/.npm + key: npm-${{ hashFiles('package-lock.json') }} + restore-keys: npm- + - name: Run bootstrap script + run: ./bootstrap.sh --ci + jobs: test: if: ${{ github.event_name == 'push' || (github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'CI/skip')) }} name: Run tests - runs-on: macOS-13 - env: - # The XCode version to use. If you want to update it please refer to this document: - # https://docs.github.com/en/actions/reference/specifications-for-github-hosted-runners#supported-software - # and set proper version. - XCODE_VERSION: "14.3.1" steps: - - name: Select XCode - # Use XCODE_VERSION env variable to set the XCode version you want. - run: sudo xcode-select --switch /Applications/Xcode_${{ env.XCODE_VERSION }}.app - - name: Checkout - uses: actions/checkout@v3 - - name: Update node - uses: actions/setup-node@v3 - with: - node-version: '18.x' - - uses: actions/cache@v3 - with: - path: ~/.npm - key: npm-${{ hashFiles('package-lock.json') }} - restore-keys: npm- - - name: Run bootstrap script - run: ./bootstrap.sh --ci - name: Run tests run: | set -o pipefail fastlane ios test + + test_latest_os: + if: github.event_name == 'pull_request' && github.event.action == 'labeled' && github.event.label.name == 'CI/latest_os' + name: Run tests on the latest available iOS simulator + steps: + - name: Run latest OS tests + run: | + set -o pipefail + fastlane ios test use_latest_os:true \ No newline at end of file diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 349cddecf9b..357e51e2ebe 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -8,9 +8,16 @@ default_platform :ios CONFIG_PATH = "../App/Configuration" LOCAL_PATH = "#{CONFIG_PATH}/Local" +DEFAULT_IOS_SIMULATOR_VERSION = "16.4" +LATEST_IOS_SIMULATOR_VERSION = "17.0" + +def device_version(options) + options[:use_latest_os] ? LATEST_IOS_SIMULATOR_VERSION : DEFAULT_IOS_SIMULATOR_VERSION +end platform :ios do before_all do |lane, options| + device_version options unless lane == :test || options[:skip_bootstrap] sh("pushd .. && ./bootstrap.sh --ci && popd") end @@ -37,7 +44,7 @@ platform :ios do run_tests( project: "App/Client.xcodeproj", scheme: "Debug", - device: "iPhone 14 (17.0)", + device: "iPhone 14 (#{device_version(options)})", code_coverage: true, ensure_devices_found: true, skip_testing: [ @@ -72,7 +79,7 @@ platform :ios do run_tests( project: "App/Client.xcodeproj", scheme: "Debug", - device: "iPad (10th generation) (17.0)", + device: "iPad (10th generation) (#{device_version(options)})", code_coverage: true, ensure_devices_found: true, skip_testing: [ From 33c9954098f2695f9e9315a9ba996d12dcc75b53 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Tue, 3 Oct 2023 20:27:32 +0200 Subject: [PATCH 05/13] revert github actions --- .github/workflows/build_and_test.yml | 52 ++++++++++++---------------- 1 file changed, 22 insertions(+), 30 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index fe337f92f34..c7b7e9e4934 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -7,43 +7,35 @@ on: - beta pull_request: -defaults: - runs-on: macOS-13 - env: - XCODE_VERSION: "14.3.1" - steps: - - name: Select XCode - run: sudo xcode-select --switch /Applications/Xcode_${{ env.XCODE_VERSION }}.app - - name: Checkout - uses: actions/checkout@v3 - - name: Update node - uses: actions/setup-node@v3 - with: - node-version: '18.x' - - uses: actions/cache@v3 - with: - path: ~/.npm - key: npm-${{ hashFiles('package-lock.json') }} - restore-keys: npm- - - name: Run bootstrap script - run: ./bootstrap.sh --ci - jobs: test: if: ${{ github.event_name == 'push' || (github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'CI/skip')) }} name: Run tests + runs-on: macOS-13 + env: + # The XCode version to use. If you want to update it please refer to this document: + # https://docs.github.com/en/actions/reference/specifications-for-github-hosted-runners#supported-software + # and set proper version. + XCODE_VERSION: "14.3.1" steps: + - name: Select XCode + # Use XCODE_VERSION env variable to set the XCode version you want. + run: sudo xcode-select --switch /Applications/Xcode_${{ env.XCODE_VERSION }}.app + - name: Checkout + uses: actions/checkout@v3 + - name: Update node + uses: actions/setup-node@v3 + with: + node-version: '18.x' + - uses: actions/cache@v3 + with: + path: ~/.npm + key: npm-${{ hashFiles('package-lock.json') }} + restore-keys: npm- + - name: Run bootstrap script + run: ./bootstrap.sh --ci - name: Run tests run: | set -o pipefail fastlane ios test - - test_latest_os: - if: github.event_name == 'pull_request' && github.event.action == 'labeled' && github.event.label.name == 'CI/latest_os' - name: Run tests on the latest available iOS simulator - steps: - - name: Run latest OS tests - run: | - set -o pipefail - fastlane ios test use_latest_os:true \ No newline at end of file From 9e38e39f7d762f37e51e0a6831c73b3e3f5e8bc6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Tue, 3 Oct 2023 20:29:10 +0200 Subject: [PATCH 06/13] defaults did not work --- .github/workflows/build_and_test.yml | 32 ++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index c7b7e9e4934..a6be1581793 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -39,3 +39,35 @@ jobs: run: | set -o pipefail fastlane ios test + + test_latest_os: + if: ${{ github.event_name == 'pull_request' && github.event.action == 'labeled' && github.event.label.name == 'CI/latest_os' }} + name: Run tests + runs-on: macOS-13 + env: + # The XCode version to use. If you want to update it please refer to this document: + # https://docs.github.com/en/actions/reference/specifications-for-github-hosted-runners#supported-software + # and set proper version. + XCODE_VERSION: "14.3.1" + + steps: + - name: Select XCode + # Use XCODE_VERSION env variable to set the XCode version you want. + run: sudo xcode-select --switch /Applications/Xcode_${{ env.XCODE_VERSION }}.app + - name: Checkout + uses: actions/checkout@v3 + - name: Update node + uses: actions/setup-node@v3 + with: + node-version: '18.x' + - uses: actions/cache@v3 + with: + path: ~/.npm + key: npm-${{ hashFiles('package-lock.json') }} + restore-keys: npm- + - name: Run bootstrap script + run: ./bootstrap.sh --ci + - name: Run tests + run: | + set -o pipefail + fastlane ios test use_latest_os:true From 228334805743917c3d2ea2db5f9824ab33fdd29b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Tue, 3 Oct 2023 20:32:29 +0200 Subject: [PATCH 07/13] labeled check --- .github/workflows/build_and_test.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index a6be1581793..87801f898ca 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -6,6 +6,7 @@ on: - development - beta pull_request: + types: [ labeled ] jobs: test: @@ -42,7 +43,7 @@ jobs: test_latest_os: if: ${{ github.event_name == 'pull_request' && github.event.action == 'labeled' && github.event.label.name == 'CI/latest_os' }} - name: Run tests + name: Run latest OS tests runs-on: macOS-13 env: # The XCode version to use. If you want to update it please refer to this document: From e2443610ff00e28b7ea87d4e0ca47ce9afe07669 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Tue, 3 Oct 2023 21:14:00 +0200 Subject: [PATCH 08/13] Add more cases --- .github/workflows/build_and_test.yml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index 87801f898ca..2dfd1ef9082 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -6,7 +6,7 @@ on: - development - beta pull_request: - types: [ labeled ] + types: [ labeled, opened, synchronize ] jobs: test: @@ -42,7 +42,16 @@ jobs: fastlane ios test test_latest_os: - if: ${{ github.event_name == 'pull_request' && github.event.action == 'labeled' && github.event.label.name == 'CI/latest_os' }} + if: >- + (github.event_name == 'pull_request' && + github.event.action == 'labeled' && + github.event.label.name == 'CI/latest_os') || + (github.event_name == 'pull_request' && + github.event.action == 'opened' && + contains(github.event.pull_request.labels.*.name, 'CI/latest_os')) || + (github.event_name == 'pull_request' && + github.event.action == 'synchronize' && + contains(github.event.pull_request.labels.*.name, 'CI/latest_os')) name: Run latest OS tests runs-on: macOS-13 env: From 138b83a12b782efff5534af07fe7c1675cb64f56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Tue, 3 Oct 2023 21:17:23 +0200 Subject: [PATCH 09/13] formatting --- .github/workflows/build_and_test.yml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index 2dfd1ef9082..dec06cc23b5 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -43,15 +43,9 @@ jobs: test_latest_os: if: >- - (github.event_name == 'pull_request' && - github.event.action == 'labeled' && - github.event.label.name == 'CI/latest_os') || - (github.event_name == 'pull_request' && - github.event.action == 'opened' && - contains(github.event.pull_request.labels.*.name, 'CI/latest_os')) || - (github.event_name == 'pull_request' && - github.event.action == 'synchronize' && - contains(github.event.pull_request.labels.*.name, 'CI/latest_os')) + (github.event_name == 'pull_request' && github.event.action == 'labeled' && github.event.label.name == 'CI/latest_os') || + (github.event_name == 'pull_request' && github.event.action == 'opened' && contains(github.event.pull_request.labels.*.name, 'CI/latest_os')) || + (github.event_name == 'pull_request' && github.event.action == 'synchronize' && contains(github.event.pull_request.labels.*.name, 'CI/latest_os')) name: Run latest OS tests runs-on: macOS-13 env: From 6868de2e363a00db36f01a8638e56ebc4e5519fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Tue, 3 Oct 2023 21:20:08 +0200 Subject: [PATCH 10/13] =?UTF-8?q?=F0=9F=91=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/build_and_test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index dec06cc23b5..3020e1cb77d 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -42,7 +42,7 @@ jobs: fastlane ios test test_latest_os: - if: >- + if: >- (github.event_name == 'pull_request' && github.event.action == 'labeled' && github.event.label.name == 'CI/latest_os') || (github.event_name == 'pull_request' && github.event.action == 'opened' && contains(github.event.pull_request.labels.*.name, 'CI/latest_os')) || (github.event_name == 'pull_request' && github.event.action == 'synchronize' && contains(github.event.pull_request.labels.*.name, 'CI/latest_os')) From 674c8fa3ab77c9f8bf0bb5b399f84aa1f662abff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Wed, 4 Oct 2023 16:48:45 +0200 Subject: [PATCH 11/13] test all. separate file --- .github/workflows/build_and_test.yml | 36 ------------------------ .github/workflows/test_all_on_pr.yml | 41 ++++++++++++++++++++++++++++ fastlane/Fastfile | 8 ++---- 3 files changed, 43 insertions(+), 42 deletions(-) create mode 100644 .github/workflows/test_all_on_pr.yml diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index 3020e1cb77d..c7b7e9e4934 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -6,7 +6,6 @@ on: - development - beta pull_request: - types: [ labeled, opened, synchronize ] jobs: test: @@ -40,38 +39,3 @@ jobs: run: | set -o pipefail fastlane ios test - - test_latest_os: - if: >- - (github.event_name == 'pull_request' && github.event.action == 'labeled' && github.event.label.name == 'CI/latest_os') || - (github.event_name == 'pull_request' && github.event.action == 'opened' && contains(github.event.pull_request.labels.*.name, 'CI/latest_os')) || - (github.event_name == 'pull_request' && github.event.action == 'synchronize' && contains(github.event.pull_request.labels.*.name, 'CI/latest_os')) - name: Run latest OS tests - runs-on: macOS-13 - env: - # The XCode version to use. If you want to update it please refer to this document: - # https://docs.github.com/en/actions/reference/specifications-for-github-hosted-runners#supported-software - # and set proper version. - XCODE_VERSION: "14.3.1" - - steps: - - name: Select XCode - # Use XCODE_VERSION env variable to set the XCode version you want. - run: sudo xcode-select --switch /Applications/Xcode_${{ env.XCODE_VERSION }}.app - - name: Checkout - uses: actions/checkout@v3 - - name: Update node - uses: actions/setup-node@v3 - with: - node-version: '18.x' - - uses: actions/cache@v3 - with: - path: ~/.npm - key: npm-${{ hashFiles('package-lock.json') }} - restore-keys: npm- - - name: Run bootstrap script - run: ./bootstrap.sh --ci - - name: Run tests - run: | - set -o pipefail - fastlane ios test use_latest_os:true diff --git a/.github/workflows/test_all_on_pr.yml b/.github/workflows/test_all_on_pr.yml new file mode 100644 index 00000000000..5cd91c2358b --- /dev/null +++ b/.github/workflows/test_all_on_pr.yml @@ -0,0 +1,41 @@ +name: Test all + +on: + pull_request: + types: [ labeled, opened, synchronize ] + +jobs: + test_all: + if: >- + (github.event_name == 'pull_request' && github.event.action == 'labeled' && github.event.label.name == 'CI/test_all') || + (github.event_name == 'pull_request' && github.event.action == 'opened' && contains(github.event.pull_request.labels.*.name, 'CI/test_all')) || + (github.event_name == 'pull_request' && github.event.action == 'synchronize' && contains(github.event.pull_request.labels.*.name, 'CI/test_all')) + name: Test all supported major platform versions + runs-on: macOS-13 + env: + # The XCode version to use. If you want to update it please refer to this document: + # https://docs.github.com/en/actions/reference/specifications-for-github-hosted-runners#supported-software + # and set proper version. + XCODE_VERSION: "14.3.1" + + steps: + - name: Select XCode + # Use XCODE_VERSION env variable to set the XCode version you want. + run: sudo xcode-select --switch /Applications/Xcode_${{ env.XCODE_VERSION }}.app + - name: Checkout + uses: actions/checkout@v3 + - name: Update node + uses: actions/setup-node@v3 + with: + node-version: '18.x' + - uses: actions/cache@v3 + with: + path: ~/.npm + key: npm-${{ hashFiles('package-lock.json') }} + restore-keys: npm- + - name: Run bootstrap script + run: ./bootstrap.sh --ci + - name: Run tests + run: | + set -o pipefail + fastlane ios test test_all:true diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 357e51e2ebe..a0cb9a73e45 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -11,10 +11,6 @@ LOCAL_PATH = "#{CONFIG_PATH}/Local" DEFAULT_IOS_SIMULATOR_VERSION = "16.4" LATEST_IOS_SIMULATOR_VERSION = "17.0" -def device_version(options) - options[:use_latest_os] ? LATEST_IOS_SIMULATOR_VERSION : DEFAULT_IOS_SIMULATOR_VERSION -end - platform :ios do before_all do |lane, options| device_version options @@ -44,7 +40,7 @@ platform :ios do run_tests( project: "App/Client.xcodeproj", scheme: "Debug", - device: "iPhone 14 (#{device_version(options)})", + devices: options[:test_all] ? ["iPhone 14 (16.4)", "iPhone 14 (17.0)"] : ["iPhone 14 (16.4)"] code_coverage: true, ensure_devices_found: true, skip_testing: [ @@ -79,7 +75,7 @@ platform :ios do run_tests( project: "App/Client.xcodeproj", scheme: "Debug", - device: "iPad (10th generation) (#{device_version(options)})", + devices: options[:test_all] ? ["iPad (10th generation) (16.4)", "iPad (10th generation) (17.0)"] : ["iPad (10th generation) (16.4)"] code_coverage: true, ensure_devices_found: true, skip_testing: [ From 3b8f3211dbae8399d7518761024cefd94dadf459 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Wed, 4 Oct 2023 17:18:25 +0200 Subject: [PATCH 12/13] , --- fastlane/Fastfile | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fastlane/Fastfile b/fastlane/Fastfile index a0cb9a73e45..8cfd1d649cc 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -8,8 +8,6 @@ default_platform :ios CONFIG_PATH = "../App/Configuration" LOCAL_PATH = "#{CONFIG_PATH}/Local" -DEFAULT_IOS_SIMULATOR_VERSION = "16.4" -LATEST_IOS_SIMULATOR_VERSION = "17.0" platform :ios do before_all do |lane, options| @@ -40,7 +38,7 @@ platform :ios do run_tests( project: "App/Client.xcodeproj", scheme: "Debug", - devices: options[:test_all] ? ["iPhone 14 (16.4)", "iPhone 14 (17.0)"] : ["iPhone 14 (16.4)"] + devices: options[:test_all] ? ["iPhone 14 (16.4)", "iPhone 14 (17.0)"] : ["iPhone 14 (16.4)"], code_coverage: true, ensure_devices_found: true, skip_testing: [ @@ -75,7 +73,7 @@ platform :ios do run_tests( project: "App/Client.xcodeproj", scheme: "Debug", - devices: options[:test_all] ? ["iPad (10th generation) (16.4)", "iPad (10th generation) (17.0)"] : ["iPad (10th generation) (16.4)"] + devices: options[:test_all] ? ["iPad (10th generation) (16.4)", "iPad (10th generation) (17.0)"] : ["iPad (10th generation) (16.4)"], code_coverage: true, ensure_devices_found: true, skip_testing: [ From fde46f84221f7e58cdcad2ce6c319f9e269e5f25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Buczek?= Date: Wed, 4 Oct 2023 17:50:29 +0200 Subject: [PATCH 13/13] compile error --- fastlane/Fastfile | 1 - 1 file changed, 1 deletion(-) diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 8cfd1d649cc..e2685cc7d41 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -11,7 +11,6 @@ LOCAL_PATH = "#{CONFIG_PATH}/Local" platform :ios do before_all do |lane, options| - device_version options unless lane == :test || options[:skip_bootstrap] sh("pushd .. && ./bootstrap.sh --ci && popd") end