Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Provide More Granular Photo Access #903

Closed
jhreis opened this issue Feb 19, 2019 · 3 comments
Closed

Provide More Granular Photo Access #903

jhreis opened this issue Feb 19, 2019 · 3 comments

Comments

@jhreis
Copy link
Contributor

jhreis commented Feb 19, 2019

Description:

Starting in iOS 11, Apple has provided a write-only photo permissions. We should support this, even if never prompted (e.g. only a native Photos permission). This is supported in other browsers (e.g. FF)

Steps to Reproduce

  1. Go into Device Settings (not Brave settings)
  2. Select Brave from app list
  3. Select Photos
  4. Select "Add Photos Only"
@magicwave
Copy link

In the described Steps to Reproduce, on my iPhone 7, iOS 12 I could not find Photos in the Brave panel from the apps list.

The version I'm running is the 1368a45 commit of the development branch, built to device with Xcode.

On iOS 12+ I think the Device path should be:
Settings > Privacy > Photos > Brave

However I am unable to verify that; there are 3rd party apps in the list but Brave is not among them. Maybe it's because Brave hasn't asked for access permissions to Photos yet, but I can't figure out how to have the Brave app prompt for them.

@iccub
Copy link
Contributor

iccub commented Dec 10, 2019

iOS 13 handles this automatically, so we only need to change iOS 12 behavior
@Brandon-T please correct me if I'm wrong

@srirambv
Copy link
Contributor

Verification passed on iPhone 6 with iOS 12.4.4 running 1.15(20.01.13.17)

  • Verified first image save prompts permission to store in Photo app
    image
  • Verified selecting OK saves the image
  • Verified selecting Don't Allow sets permission to Never
  • Verified when set to never shows the following prompt
    image

Verification passed on iPhone 6 with iOS 12.4.4 running 1.15(20.01.13.17)

  • Verified first image save prompts permission to store in Photo app
    image
  • Verified selecting OK saves the image
  • Verified selecting Don't Allow sets permission to Never
  • Verified when set to never shows the following prompt
    image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants