Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

The whole text doesn't fit the size of the cookie consent notices pop-up message. #8168

Closed
hffvld opened this issue Sep 27, 2023 · 2 comments

Comments

@hffvld
Copy link
Collaborator

hffvld commented Sep 27, 2023

Description:

Need to shrink the text on the cookie consent notices pop-up message to fit the stings and CTA button in some languages.

Steps to Reproduce

  1. Change device language to German, French or Russian, for example
  2. Fresh install and launch Brave > Go through the onboarding flow
  3. Close and relaunch Brave to see the cookie consent notices pop-up message > Observe

Actual result:

The cookie consent notices pop-up message is too long for the message window in some languages, and some of the text is cut off. The user needs to scroll through it to see the Got it CTA button. This is happening, for example, for German, French or Russian languages.

French French German
1 2 3
Russian Russian English
1 2 3

Expected result:

The whole text must fit the size of the cookie consent notices pop-up message.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.58 (23.9.26.21)
BraveCore: 1.58.129 (117.0.5938.88)

  • Can you reproduce this issue with the most recent build from TestFlight? YES
  • Can you reproduce this issue with the previous version of the current build from TestFlight? YES
  • Can you reproduce this issue with the current build from AppStore? YES

Device details:

iPhone 14 [iOS 17.0]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@iccub
Copy link
Contributor

iccub commented Oct 4, 2023

We will most likely drop this modal. may be invalid issue

@soner-yuksel
Copy link
Contributor

The popover is removed entirely #8230
1.59

@iccub iccub closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants