Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix:6964: Shields panel url should show origin only, not full url #7042

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Mar 1, 2023

Summary of Changes

Shield panel origin of url display and format url string test functions

This pull request fixes #6964

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Go to some wikipedia article

  • Open shields panel

Screenshots:

Simulator Screen Shot - iPhone 14 Pro - 2023-03-01 at 16 18 03

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.49 milestone Mar 1, 2023
@soner-yuksel soner-yuksel requested a review from a team as a code owner March 1, 2023 21:38
@soner-yuksel soner-yuksel self-assigned this Mar 1, 2023
@soner-yuksel soner-yuksel changed the title Fix:6964: elds panel url should show origin only, not full url Fix:6964: Shields panel url should show origin only, not full url Mar 1, 2023
@Brandon-T Brandon-T merged commit 2c58fac into development Mar 2, 2023
@Brandon-T Brandon-T deleted the fix/shield-panel-origin branch March 2, 2023 03:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shields panel url should show origin only, not full url
3 participants