Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

First video missing on youtube home page when signed in [iPad] #6666

Closed
Uni-verse opened this issue Dec 23, 2022 · 8 comments
Closed

First video missing on youtube home page when signed in [iPad] #6666

Uni-verse opened this issue Dec 23, 2022 · 8 comments

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Dec 23, 2022

Description:

First video not shown on youtube home page when logged in

related to brave/brave-browser#11955

Steps to Reproduce

  1. Install 1.46.x
  2. sign into google.com
  3. open youtube.com

Actual result:
IMG_0077

Expected result:
IMG_0078 2

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily

Brave Version:
1.46 (22.12.15.19)

Device details:
iPad

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@Uni-verse
Copy link
Contributor Author

Looks like its happening on desktop client as well.

cc: @kjozwiak

@kjozwiak
Copy link
Member

kjozwiak commented Jan 6, 2023

Looks like its happening on desktop client as well.

cc: @kjozwiak

yup, also happening on desktop as well. I believe it's due to removing ad videos that usually appear in that spot. Maybe we can shift the videos over by one so we're not displaying this white space. Pretty sure this is due to cosmetic filtering. We had some issues in the past as some area's stay blank that have been blocked by Brave.

image

@iccub
Copy link
Contributor

iccub commented Jan 9, 2023

Isn't this an ad taking first spot here?

@kjozwiak
Copy link
Member

kjozwiak commented Jan 9, 2023

Isn't this an ad taking first spot here?

@iccub yup, I guess the issue is to see if we can shift things over? Probably easier said then done but not sure if it's even worth it. I guess we can leave this opened as there's some users complaining about there being a blank area. But it's due to the ad video being removed as you mentioned above. I wouldn't consider this high priority though.

@iccub
Copy link
Contributor

iccub commented Jan 10, 2023

any opinion on that @ryanbr?

@ryanbr
Copy link

ryanbr commented Jan 11, 2023

The blank space is just the uncollapsed advert that was removed. When we get procedural filters support in brave/brave-browser#16935 it should help. I think we can all agree, having a blank space isn't ideal is far better than showing the advert.

youtube.com##ytd-display-ad-renderer:upward(ytd-rich-item-renderer) The filter used in uBO. upward isn't currently supported

@iccub
Copy link
Contributor

iccub commented Mar 8, 2023

closing as wontfix for now

@iccub iccub closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2023
@ryanbr
Copy link

ryanbr commented Mar 8, 2023

If brave/brave-browser#27874 is supported on ios, this empry space should be fixed also

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants