Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

'Try Brave Search' button cut in other languages #5644

Closed
iccub opened this issue Jul 5, 2022 · 2 comments
Closed

'Try Brave Search' button cut in other languages #5644

iccub opened this issue Jul 5, 2022 · 2 comments
Assignees
@soner-yuksel
Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.41

Comments

@iccub
Copy link
Contributor

iccub commented Jul 5, 2022

Description:

Steps to Reproduce

  1. Use other than english language
  2. Trigger the Brave Search popup by not having B-S set as default

Actual result:
IMG_29EFA711BB80-1 (1)

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@iccub iccub added this to the 1.41 milestone Jul 5, 2022
@iccub
Copy link
Contributor Author

iccub commented Jul 5, 2022

Fixed here #5639

@iccub iccub closed this as completed Jul 5, 2022
@iccub iccub modified the milestones: 1.41, 1.40.1 Jul 5, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 6, 2022 •
edited
Loading

Verified using 1.40.1 (22.7.5.21)

Test Devices:
iPhone 12 Pro | iOS 15.5
iPhone X | iOS 14.4.2
iPad (7th Gen) | iOS 15.5

  • Try Brave Search button in search promo cell is not cut off in other languages.
  • Search promo cell displayed correctly after dismissing the search promo cell the first time.
iPhone iPad
1 2
Dismiss Once (iPhone) Dismiss Once (iPad)
3 4
iOS 14 Dismiss Once (iOS 14)
5 6

@Uni-verse Uni-verse mentioned this issue Jul 7, 2022
Closed
@iccub iccub modified the milestones: 1.40.1, 1.41 Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@soner-yuksel soner-yuksel

Labels
bug QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.41
Development

No branches or pull requests
4 participants
@kjozwiak @soner-yuksel @iccub @Uni-verse