Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Playlists #3368

Closed
iccub opened this issue Mar 3, 2021 · 3 comments · Fixed by #3384
Closed

Playlists #3368

iccub opened this issue Mar 3, 2021 · 3 comments · Fixed by #3384

Comments

@iccub
Copy link
Contributor

iccub commented Mar 3, 2021

No description provided.

@srirambv
Copy link
Contributor

QA Blocked on spec. @anthonypkeane please link the spec so QA can start testing it.

@anthonypkeane
Copy link

Unblocking as Spec provided

@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.5 running 1.25(21.4.28.19)
  • Verified visiting a YT video shows `Add to Brave Playlist` toast
  • Verified toast can be dismissed via swipe down
  • Verified clicking on toast adds the video to playlist
  • Verified once video is added to playlist, a confirmation toast is shown with open. Clicking that opens the playlist
  • Verified videos can be played on playlist while streaming
  • Verified able to add videos to playlist via toast/share menu/long press
  • Verified once video is added to playlist it is auto saved for offline viewing
  • Verified able to cancel offline saving feature by swipe and tap on the download cloud button
  • Verified able to remove a video from playlist via swipe left and selecting remove from confirmation prompt
  • Verified when playing a video from playlist, background the app doesn't activates picture-in-picture mode
  • Verified settings changed are retained between restarts
  • Verified tap on 15 sec back/forward buttons seeks the video 15sec back/forward
  • Verified able to zoom the video by double tapping on video
  • Verified locking screen while playing causes it to pause but can continue to background play by clicking on the play button on lockscreen
  • Verified video auto plays to next one after the current video is done playing
  • Verified able to skip to the next media
  • Verified videos doesn't loop once the last video in the playlist is done playing
  • Verified newly added videos are on top of the list
  • Verified able to seek video back/forward or increase/decrease volume via control center on lock screen
  • Verified when a video is put for offline play and network disrupts, video is buffered to download and continues to download when network is back
  • Verified videos are saved for offline even when browser is not active
  • Verified videos can be sorted/ordered by moving up/down
  • Verified embedded videos on pages don't trigger toast to add to playlist but can still be added to playlist via share menu
  • Verified selecting `Playlist Offline Data` under clear private data only clears saved videos but doesn't remove the videos itself from the list
  • Verified selecting `Playlist Media & Offline Data` clears everything from playlist
  • Verified no crash when clearing playlist data

Verification passed on iPhone 7+ with iOS 14.5 running 1.25(21.4.28.19)
  • Verified visiting a YT video shows `Add to Brave Playlist` toast
  • Verified toast can be dismissed via swipe down
  • Verified clicking on toast adds the video to playlist
  • Verified once video is added to playlist, a confirmation toast is shown with open. Clicking that opens the playlist
  • Verified videos can be played on playlist while streaming
  • Verified able to add videos to playlist via toast/share menu/long press
  • Verified once video is added to playlist it is auto saved for offline viewing
  • Verified able to cancel offline saving feature by swipe and tap on the download cloud button
  • Verified able to remove a video from playlist via swipe left and selecting remove from confirmation prompt
  • Verified when playing a video from playlist, background the app activates picture-in-picture mode
  • Verified settings changed are retained between restarts
  • Verified tap on 15 sec back/forward buttons seeks the video 15sec back/forward
  • Verified able to zoom the video by double tapping on video
  • Verified locking screen while playing continue to background play and can be controled via lock screen controls
  • Verified video auto plays to next one after the current video is done playing
  • Verified able to skip to the next media
  • Verified videos doesn't loop once the last video in the playlist is done playing
  • Verified newly added videos are on top of the list
  • Verified able to seek video back/forward or increase/decrease volume via control center on lock screen
  • Verified when a video is put for offline play and network disrupts, video is buffered to download and continues to download when network is back
  • Verified videos are saved for offline even when browser is not active
  • Verified videos can be sorted/ordered by moving up/down
  • Verified embedded videos on pages don't trigger toast to add to playlist but can still be added to playlist via share menu
  • Verified selecting `Playlist Offline Data` under clear private data only clears saved videos but doesn't remove the videos itself from the list
  • Verified selecting `Playlist Media & Offline Data` clears everything from playlist
  • Verified no crash when clearing playlist data

Verification passed on iPad Pro with iOS 14.4.2 running 1.25(21.4.28.19)
  • Verified visiting a YT video shows `Add to Brave Playlist` toast
  • Verified toast can be dismissed via swipe down
  • Verified clicking on toast adds the video to playlist
  • Verified once video is added to playlist, a confirmation toast is shown with open. Clicking that opens the playlist
  • Verified videos can be played on playlist while streaming
  • Verified able to add videos to playlist via toast/share menu/long press
  • Verified once video is added to playlist it is auto saved for offline viewing
  • Verified able to cancel offline saving feature by swipe and tap on the download cloud button
  • Verified able to remove a video from playlist via swipe left and selecting remove from confirmation prompt
  • Verified when playing a video from playlist, background the app activates picture-in-picture mode
  • Verified settings changed are retained between restarts
  • Verified tap on 15 sec back/forward buttons seeks the video 15sec back/forward
  • Verified able to zoom the video by double tapping on video
  • Verified locking screen while playing continue to background play and can be controled via lock screen controls
  • Verified video auto plays to next one after the current video is done playing
  • Verified able to skip to the next media
  • Verified videos doesn't loop once the last video in the playlist is done playing
  • Verified newly added videos are on top of the list
  • Verified able to seek video back/forward or increase/decrease volume via control center on lock screen
  • Verified when a video is put for offline play and network disrupts, video is buffered to download and continues to download when network is back
  • Verified videos are saved for offline even when browser is not active
  • Verified videos can be sorted/ordered by moving up/down
  • Verified embedded videos on pages don't trigger toast to add to playlist but can still be added to playlist via share menu
  • Verified selecting `Playlist Offline Data` under clear private data only clears saved videos but doesn't remove the videos itself from the list
  • Verified selecting `Playlist Media & Offline Data` clears everything from playlist
  • Verified no crash when clearing playlist data

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.