Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Support Full Page Screenshots of Brave (like Safari) #2806

Closed
jonathansampson opened this issue Aug 11, 2020 · 4 comments · Fixed by #6825
Closed

Support Full Page Screenshots of Brave (like Safari) #2806

jonathansampson opened this issue Aug 11, 2020 · 4 comments · Fixed by #6825

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Aug 11, 2020

Problem Description

It is not easy to take a full-document screenshot with Brave. It is easy to do this with Safari. When you take a screenshot from within Safari, you are offered the option of extending the screenshot to the full document height. When you take a screenshot from within Brave, this option is not presented.

Developer Information

See https://developer.apple.com/documentation/uikit/uiwindowscene/3213938-screenshotservice

@kylehickinson
Copy link
Collaborator

We will add saving to PDF support in iOS 14 (#2807).

Will look into seeing if we can hook into this to provide support for the screenshot service as well. Im not sure if we'll be able to get all the same stuff as Safari. If it ends up replacing the regular screenshot, we will likely have to not implement it since we won't have a way to toggle between taking a screenshot of the web page vs taking a screenshot of the screen

@kylehickinson
Copy link
Collaborator

Upon further investigation this will require us to implement a scene delegate, which will require more work so not as simple as hooking it up with the same PDF support unfortunately

@NeonSpaceTurtle
Copy link

Upon further investigation this will require us to implement a scene delegate, which will require more work so not as simple as hooking it up with the same PDF support unfortunately

still looking for a solution. most chrome addons are broken in brave, haven't been able to use a single addon that works so far. this is the most annoying part of being in brave as I do need to save screenshot of scrolled pages.

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.49 (23.3.15.17)

  • Verified steps from #6825
  • Verified able to take full page screenshots
  • Verified full page screenshot is saved as a .pdf file in specified location
  • Verified able to take full page screenshot on both http/https pages
  • Verified taking a screenshot at the bottom of the page and selecting full page saves the full page length as screenshot
  • Verified works on both landscape and portrait mode
iPhone 7+ (iOS 15.7.3) iPhone XR (iOS 16.3.1) iPad Pro (16.4 Beta 2)
2806-iPhone.7+.MP4
2806-iPhone.X.MP4
2806-iPad.MP4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.