Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

BAT Confirmations should not be started if Rewards is disabled #2629

Closed
LaurenWags opened this issue Jun 12, 2020 · 2 comments
Closed

BAT Confirmations should not be started if Rewards is disabled #2629

LaurenWags opened this issue Jun 12, 2020 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description:

Logging per brave/brave-core#5424

Above PR fixes brave/brave-browser#9544 and per the PR it should also be checked on iOS.

See above issue/PR for more information.

cc @srirambv

Additional Information

cc @kylehickinson to review and place in appropriate milestone as this code might already be in iOS

@kylehickinson
Copy link
Collaborator

kylehickinson commented Jun 12, 2020

Code is already in iOS as our current BraveRewards framework is built off of 1.10.52 and this was merged at 1.10.28, meaning its already shipping in 1.17. This milestone is closed however so I can't add it to that. @LaurenWags Do you want me to add it to 1.18 to test in iOS or fine to leave it?

Here is the PR that merged this change inadvertently: #2566

@LaurenWags
Copy link
Member Author

let's test with next iOS release that goes out unless @srirambv feels differently 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants