Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Expand Rewards to three decimal places #2596

Closed
tmancey opened this issue Jun 2, 2020 · 1 comment · Fixed by #2638
Closed

Expand Rewards to three decimal places #2596

tmancey opened this issue Jun 2, 2020 · 1 comment · Fixed by #2638
Assignees
@tmancey
Labels
enhancement Epic: Rewards priority/P3 The next thing for us to work on. QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.19

Comments

@tmancey
Copy link
Collaborator

tmancey commented Jun 2, 2020 •
edited by kylehickinson
Loading

See brave/brave-browser#10027

Currently the estimated pending rewards display on the brave://rewards page, the estimated pending rewards display on the new tab page widget, and the ad grant claimed amounts round to one decimal place. They should round to 3 decimal places so that users can see ads that yield less than 0.1 BAT per view
@tmancey tmancey self-assigned this Jun 16, 2020
@tmancey tmancey mentioned this issue Jun 16, 2020
Merged
7 tasks
@tmancey tmancey added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Jun 16, 2020
@tmancey tmancey added release-notes/include priority/P3 The next thing for us to work on. and removed release-notes/exclude priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 16, 2020
@tmancey tmancey added this to the 1.19 milestone Jun 16, 2020
@srirambv srirambv mentioned this issue Jul 17, 2020
Closed
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.5 running 1.19(20.07.16.15)

  • Verified rewards value has 3 decimal places

Verification passed on iPhone 7+ with iOS 13.5.1 running 1.19(20.07.16.15)

  • Verified rewards value has 3 decimal places

Verification passed on iPhone 6 with iOS 12.4.7 running 1.19(20.07.16.15)

  • Verified rewards value has 3 decimal places

Verification passed on iPad Pro with iOS 13.6 running 1.19(20.07.16.15)

  • Verified rewards value has 3 decimal places

Verification passed on iPad Pro with iOS 12.4.1 running 1.19(20.07.16.15)

  • Verified rewards value has 3 decimal places

Logged follow up issue #2721 for missing 3 decimal places

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tmancey tmancey

Labels
enhancement Epic: Rewards priority/P3 The next thing for us to work on. QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.19
Development

Successfully merging a pull request may close this issue.

Expand Rewards to three decimal places brave/brave-ios
3 participants
@kylehickinson @tmancey @srirambv