Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Updating Package-Lock.json #2423

Closed
Brandon-T opened this issue Mar 24, 2020 · 1 comment · Fixed by #2416
Closed

Updating Package-Lock.json #2423

Brandon-T opened this issue Mar 24, 2020 · 1 comment · Fixed by #2416

Comments

@Brandon-T
Copy link
Collaborator

Description:

  • https://github.com/brave/brave-ios/network/alert/package-lock.json/minimist/open
  • Just related to outdated libraries being used across all platforms for millions of applications.
  • We updated the packages so we need to make sure stuff still works.

Steps to Reproduce

  1. N/A

Expected result:

  • Sync should work

Brave Version:

  • All
@srirambv
Copy link
Contributor

srirambv commented Apr 9, 2020

Verification passed on iPhone XR with iOS 13.4 running 1.15.1(20.04.07.18)

  • Verified sync between iPhone XR <--> Desktop (1.8.69) works fine. Adding/removing/reordering/editing bookmarks on both devices propagate correctly
  • Verified sync between iPhone XR <--> Android (1.5.131) works fine. Adding/Removing/Reordering/Editing bookmarks on both devices propagate correctly
  • Verified sync between iPhone XR <--> iPhone 7+(1.15.1) works fine. Adding/Removing/Reordering/Editing bookmarks on both devices propagate correctly
  • Verified stats are retained when sync is enabled
  • Verified stats are retained when sync is reset

Verification passed on iPhone 7+ with iOS 13.3.1 running 1.15.1(20.04.07.18)

  • Verified sync between iPhone 7+ <--> Desktop (1.8.69) works fine. Adding/removing/reordering/editing bookmarks on both devices propagate correctly
  • Verified sync between iPhone 7+ <--> Android (1.5.131) works fine. Adding/Removing/Reordering/Editing bookmarks on both devices propagate correctly
  • Verified sync between iPhone 7+ <--> iPad Pro (iOS 13.3.1) (1.15.1) works fine. Adding/Removing/Reordering/Editing bookmarks on both devices propagate correctly
  • Verified stats are retained when sync is enabled
  • Verified stats are retained when sync is reset

Verification passed on iPad Pro with iOS 13.3.1 running 1.15.1(20.04.07.18)

  • Verified sync between iPad Pro <--> Desktop (1.8.72) works fine. Adding/removing/reordering/editing bookmarks on both devices propagate correctly
  • Verified sync between iPad Pro <--> Android (1.5.131) works fine. Adding/Removing/Reordering/Editing bookmarks on both devices propagate correctly
  • Verified sync between iPad Pro <--> iPhone 7+(1.15.1) works fine. Adding/Removing/Reordering/Editing bookmarks on both devices propagate correctly
  • Verified stats are retained when sync is enabled
  • Verified stats are retained when sync is reset

Verification passed on iPad Pro with iOS 12.4.5 running 1.15.1(20.04.07.18)

  • Verified sync between iPad Pro <--> Desktop (1.8.72) works fine. Adding/removing/reordering/editing bookmarks on both devices propagate correctly
  • Verified sync between iPad Pro <--> Android (1.5.131) works fine. Adding/Removing/Reordering/Editing bookmarks on both devices propagate correctly
  • Verified sync between iPad Pro <--> iPhone XR (1.15.1) works fine. Adding/Removing/Reordering/Editing bookmarks on both devices propagate correctly
  • Verified stats are retained when sync is enabled
  • Verified stats are retained when sync is reset

Verification passed on iPhone 6 with iOS 12.4.5 running 1.15.1(20.04.07.18)

  • Verified sync between iPhone 6 <--> Desktop (1.8.69) works fine. Adding/removing/reordering/editing bookmarks on both devices propagate correctly
  • Verified sync between iPhone 6 <--> Android (1.5.131) works fine. Adding/Removing/Reordering/Editing bookmarks on both devices propagate correctly
  • Verified sync between iPhone 6 <--> iPad Pro (iOS 13.3.1) (1.15.1) works fine. Adding/Removing/Reordering/Editing bookmarks on both devices propagate correctly
  • Verified stats are retained when sync is enabled
  • Verified stats are retained when sync is reset

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.