Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Disable Background Playback Flag #2387

Closed
jhreis opened this issue Mar 3, 2020 · 2 comments
Closed

Disable Background Playback Flag #2387

jhreis opened this issue Mar 3, 2020 · 2 comments

Comments

@jhreis
Copy link
Contributor

jhreis commented Mar 3, 2020

Description:

Since iOS 13 webkit has a bug that prevents audio playback, we should remove the flag associated with this feature.

This should have 0 impact to iOS 13, due to the existing but.

For iOS 12, this will remove the current feature of background playback.

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@jhreis
Copy link
Contributor Author

jhreis commented Mar 3, 2020

Fixed per:
commit: 23ba88f
PR: #2385

@LaurenWags
Copy link
Member

LaurenWags commented Mar 5, 2020

Verification passed on iPad 5th Gen with iOS 12 running 1.15 (20.3.5.14)

  • Verified test plan from No Bug: Remove audio background mode[dev branch] #2385
  • Ensured when playing a song on Soundcloud and backgrounding the app, the song did not immediately stop playing.
  • Ensured behavior on Soundcloud was the same on both 1.15 and 1.14.3 (20.02.01.06)
  • Ensured when playing a video on YouTube and backgrounding the app, the song immediately stopped playing.

Verification passed on iPad mini with iOS 13 running 1.15 (20.3.5.14)

  • Verified test plan from No Bug: Remove audio background mode[dev branch] #2385
  • Ensured when playing a song on Soundcloud and backgrounding the app, the song did not immediately stop playing.
  • Ensured behavior on Soundcloud was the same on both 1.15 and 1.14.3 (20.02.01.06)
  • Ensured when playing a video on YouTube and backgrounding the app, the song immediately stopped playing.

Verification PASSED on iPhone 6s+ running iOS 12.4.1 using 1.15 (20.03.05.13):

  • Verified test plan from No Bug: Remove audio background mode[dev branch] #2385
  • Ensured when playing a song on Soundcloud and backgrounding the app, the song did not immediately stop playing.
  • Ensured behavior on Soundcloud was the same on both 1.15 and 1.14.3 (20.02.01.06)
  • Ensured when playing a video on YouTube and backgrounding the app, the song immediately stopped playing.

Verification PASSED on iPhone 11 running iOS 13.3.1 using 1.15 (20.03.05.13):

  • Verified test plan from No Bug: Remove audio background mode[dev branch] #2385
  • Ensured when playing a song on Soundcloud and backgrounding the app, the song did not immediately stop playing.
  • Ensured behavior on Soundcloud was the same on both 1.15 and 1.14.3 (20.02.01.06)
  • Ensured when playing a video on YouTube and backgrounding the app, the song immediately stopped playing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants