Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Closing a private tab switches theme from dark to light #1862

Closed
srirambv opened this issue Oct 31, 2019 · 2 comments · Fixed by #3606
Closed

Closing a private tab switches theme from dark to light #1862

srirambv opened this issue Oct 31, 2019 · 2 comments · Fixed by #3606

Comments

@srirambv
Copy link
Contributor

Description:

Closing a private tab causes theme to switch from dark to light

Steps to Reproduce

  1. Set device theme to dark
  2. Visit a site with link
  3. Long press on a link and open in a private tab
  4. Exit private tab
  5. Open normal tab again, theme is changed to light from dark even though device theme is still set to dark

Actual result:
private_light

Expected result:
Not change theme when exiting private tab

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.13(19.10.31.19)

Device details:
iPhone 7+ (iOS 13.2)
iPhone XR (iOS 13.2)

Website problems only:

  • did you check with Brave Shields down? N?A
  • did you check in Safari/Firefox (WkWebView-based browsers)? N/A

Additional Information

@srirambv srirambv added this to the 1.13 milestone Oct 31, 2019
@srirambv srirambv changed the title Closing a private tab causes switches theme from dark to light Closing a private tab switches theme from dark to light Oct 31, 2019
@iccub iccub removed this from the 1.13 milestone Nov 1, 2019
@iccub
Copy link
Contributor

iccub commented Nov 1, 2019

This doesn't seem to happen when not using quick switcher, moving out of 1.13 release

@srirambv
Copy link
Contributor Author

Verification passed on iPhone XR with iOS 13.5 running 1.26(21.5.25.18)

  • Verified steps from issue description
  • Verified theme doesn't switch when exiting from private tab

Verification passed on iPhone 7+ with iOS 14.5.1 running 1.26(21.5.25.18)

  • Verified steps from issue description
  • Verified theme doesn't switch when exiting from private tab

Verification passed on iPad Pro with iOS 14.5.1 running 1.26(21.5.25.18)

  • Verified steps from issue description
  • Verified theme doesn't switch when exiting from private tab

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.