Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Implement the NTP image #1782

Closed
anthonypkeane opened this issue Oct 23, 2019 · 1 comment
Closed

Implement the NTP image #1782

anthonypkeane opened this issue Oct 23, 2019 · 1 comment

Comments

@anthonypkeane
Copy link

anthonypkeane commented Oct 23, 2019

Description:

Please implement the NTP image

Search GDocs for the Spec

cc @jhreis

Test Plan

Default new behavior:

  1. open new browser install
  2. see background image!

Default upgrade behavior:

  1. upgrade browser
  2. open
  3. see background image!

Turn off:

  1. Go into Settings > New Tab Page > Turn off "Show Background Images"
  2. Going back to main screen should see a background without an image (may be dark, or have gradient on white background depending on your current theme).
  3. Opening new tabs should not show any background images

Turn On:

  1. Go into Settings > New Tab Page > Turn on "Show Background Images"
  2. Going back to NTP, should see a background image
  3. Opening subsequent new tabs should continue showing background images

Addition thing to note during above testing. You should never see an image appear twice on a fresh new tab page. Since the NTP is cached while it is open (e.g. creating 6 tabs at the same time), sibling NTP's will show the same image. But if you close the NTP and open a new one, it should always have a different background. Please inquire if clarity is needed.

@srirambv
Copy link
Contributor

srirambv commented Dec 5, 2019

Verification passed on iPhone XR with iOS 13.2 running 1.14(19.12.05.18)
Clean install

  • Verified new tab shows an image
  • Verified toggle setting disables images on new tabs and existing new tabs
  • Verified enabling the setting shows images on all existing new tabs and new ones
  • Verified opening a private tab shows the new tab images
  • Verified setting toggles work on both normal and private tabs
  • Verified opening N new tabs retain the same image until a page is loaded in one of the tabs

Upgrade install

  • Verified on upgrade new tabs show images by default

Verification passed on iPhone 7+ with iOS 13.2 running 1.14(19.12.05.18)
Clean install

  • Verified new tab shows an image
  • Verified toggle setting disables images on new tabs and existing new tabs
  • Verified enabling the setting shows images on all existing new tabs and new ones
  • Verified opening a private tab shows the new tab images
  • Verified setting toggles work on both normal and private tabs
  • Verified opening N new tabs retain the same image until a page is loaded in one of the tabs

Upgrade install

  • Verified on upgrade new tabs show images by default

Verification passed on iPhone 6 with iOS 12.4 running 1.14(19.12.05.18)
Clean install

  • Verified new tab shows an image
  • Verified toggle setting disables images on new tabs and existing new tabs
  • Verified enabling the setting shows images on all existing new tabs and new ones
  • Verified opening a private tab shows the new tab images
  • Verified setting toggles work on both normal and private tabs
  • Verified opening N new tabs retain the same image until a page is loaded in one of the tabs

Upgrade install

  • Verified on upgrade new tabs show images by default

Verification passed on iPad Pro with iOS 13.2 running 1.14(19.12.05.18)
Clean install

  • Verified new tab shows an image
  • Verified toggle setting disables images on new tabs and existing new tabs
  • Verified enabling the setting shows images on all existing new tabs and new ones
  • Verified opening a private tab shows the new tab images
  • Verified setting toggles work on both normal and private tabs
  • Verified opening N new tabs retain the same image until a page is loaded in one of the tabs
  • Verified opening N new tabs retain the same image until a page is loaded in one of the tabs

Upgrade install

  • Verified on upgrade new tabs show images by default

Verification passed on iPad Pro with iOS 12.4 running 1.14(19.12.05.18)
Clean install

  • Verified new tab shows an image
  • Verified toggle setting disables images on new tabs and existing new tabs
  • Verified enabling the setting shows images on all existing new tabs and new ones
  • Verified opening a private tab shows the new tab images
  • Verified setting toggles work on both normal and private tabs
  • Verified opening N new tabs retain the same image until a page is loaded in one of the tabs

Upgrade install

  • Verified on upgrade new tabs show images by default

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants