Start browsing button delay is too long looks like onboarding is stuck

[srirambv]

Description:

Joining rewards triggers sample ad notification and then waits for 8secs with the counter at 0. It gives a feeling that the onboarding is stuck. We should consider reducing the wait time before showing the Start Browsing button.

Steps to Reproduce

1. Go through onboarding flow

Actual result:

Expected result:
No UI stall making it look like its stuck without visual feedback

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.13

Device details:
All

Website problems only:

• did you check with Brave Shields down?
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

cc: @jamesmudgett @karenkliu @kylehickinson

[Brandon-T]

@srirambv I implemented it like this on purpose. I don't actually know if what I did was wrong or not.

Logic:

1. Display countdown.
2. When it hits 0, show my first ad notification.
3. a. If the notification is dismissed naturally, show "Start Browsing".
   b. If the notification is dismissed manually, immediately go to a new browsing tab for ads.

It doesn't show the "Start Browsing" unless the ad disappears either manually or naturally.

[kylehickinson]

@Brandon-T Nah that's how it was spec'd out its fine. We chatted about it with @karenkliu in Slack and we are likely going to replace the leaving "0" with something that makes it more obvious the user should interact with the ad above

That mixed with #1703 should make that a bit better

[Brandon-T]

Ok, for now, I'll leave it assigned to Karen and when it gets updated, I'll reassign it to myself if no one takes it or we can just auto-assign it to me.

[kylehickinson]

Closed in favour of #1746