Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Dismissing my first ad opens a new tab anyways #1652

Closed
kylehickinson opened this issue Oct 1, 2019 · 2 comments
Closed

Dismissing my first ad opens a new tab anyways #1652

kylehickinson opened this issue Oct 1, 2019 · 2 comments
Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.13

Comments

@kylehickinson
Copy link
Collaborator

Saw this happen during screen-share with Danish. He swiped upwards to dismiss and it opened tab anyways. Not sure if it was due to a tap registering while it was dismissing or not.

It should only open when user clicks directly on it
@danishjafri88 danishjafri88 self-assigned this Oct 3, 2019
@anthonypkeane anthonypkeane transferred this issue from brave/brave-rewards-ios Oct 15, 2019
@kylehickinson kylehickinson added this to the 1.13 milestone Oct 16, 2019
@kylehickinson
Copy link
Collaborator Author

Couldn't reproduce, please re-open if reproduced

@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.2 running 1.13(19.10.25.14)

  • Verified dismissing the notification doesn't open a new tab
  • Verified left swipe dismisses the notification and doesn't open a new tab

Verification passed on iPhone XR with iOS 13.2 running 1.13(19.10.25.14)

  • Verified dismissing the notification doesn't open a new tab
  • Verified left swipe dismisses the notification and doesn't open a new tab

Verification passed on iPhone 7+ with iOS 13.2 running 1.13(19.10.25.14)

  • Verified dismissing the notification doesn't open a new tab
  • Verified left swipe dismisses the notification and doesn't open a new tab

Verification passed on iPad Pro with iOS 13.2 running 1.13(19.10.25.14)

  • Verified dismissing the notification doesn't open a new tab
  • Verified left swipe dismisses the notification and doesn't open a new tab

Verification passed on iPhone 6 with iOS 12.4 running 1.13(19.10.25.14)

  • Verified dismissing the notification doesn't open a new tab
  • Verified left swipe dismisses the notification and doesn't open a new tab

Verification passed on iPad Pro with iOS 12.4 running 1.13(19.10.25.14)

  • Verified dismissing the notification doesn't open a new tab
  • Verified left swipe dismisses the notification and doesn't open a new tab

@srirambv srirambv mentioned this issue Nov 7, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
4 participants
@kylehickinson @danishjafri88 @anthonypkeane @srirambv