Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

not all PB text being translated #1239

Closed
kjozwiak opened this issue Jul 12, 2019 · 3 comments
Closed

not all PB text being translated #1239

kjozwiak opened this issue Jul 12, 2019 · 3 comments
Milestone

Comments

@kjozwiak
Copy link
Member

Description:

The first part of the PB text isn't being translated. However, the expanded text will be in the correct locale.

Steps to Reproduce

  1. Change the device language to something other than english
  2. launch Brave and open a PB tab

Actual result:

IMG_9755

Expected result:

The first part of the PB text should also be translated into the correct locale.

Reproduces how often: [Easily reproduced, Intermittent Issue]

100% reproducible using the above STR.

Brave Version:

  • Using 1.10 (19.07.10.17)

Device details:

  • iPad Mini 4 running iOS 12.3.1 using 1.10 (19.07.10.17) - Reproduced
  • iPhone 6s+ running iOS 12.3.1 using 1.10 (19.07.10.17) - Reproduced

Website problems only:

  • did you check with Brave Shields down? N/A
  • did you check in Safari/Firefox (WkWebView-based browsers)? N/A

Additional Information

@kjozwiak kjozwiak added bug QA/Yes l10n translation issues labels Jul 12, 2019
@kjozwiak kjozwiak added this to the 1.10 milestone Jul 12, 2019
@kjozwiak
Copy link
Member Author

This is also reproducible on 1.9.3 (19.05.22.15) which is the latest production release that's on the App Store. So definitely not a new regression.

@danishjafri88
Copy link
Contributor

Resolved

@LaurenWags
Copy link
Member

LaurenWags commented Jul 17, 2019

  • Verified passed on iPad 5th Gen (iOS 12.3.1) running 1.10 (19.07.16.23)

IMG_270312B569AC-1

IMG_468686AF2D68-1

  • Verification PASSED on iPhone 6s+ running iOS 12.3.1 using 1.10 (19.07.16.23)
    • checked using Italian, Portuguese and Japanese

IMG_9772

IMG_9771

IMG_9770

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants