Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Main Menu Redesign #1130

Closed
jhreis opened this issue Jun 6, 2019 · 5 comments
Closed

Main Menu Redesign #1130

jhreis opened this issue Jun 6, 2019 · 5 comments

Comments

@jhreis
Copy link
Contributor

jhreis commented Jun 6, 2019

Description:

New menu design. This combines the menu on top left and bottom right into a single centralized menu. Redesigns how

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@LaurenWags
Copy link
Member

@jhreis where can QA find the expected design for this menu?

@jamesmudgett
Copy link
Contributor

Menu v1

@kjozwiak kjozwiak added this to the 1.10 milestone Jul 17, 2019
@kjozwiak
Copy link
Member

@LaurenWags #1184 has some info on the ordering of the new designed menu as well 👍

@kjozwiak
Copy link
Member

kjozwiak commented Jul 17, 2019

@anthonypkeane @EyanGoldman as this is a design/UX issue, can you guys go through this on an iPhone X? If you've already been dog fooding and feel comfortable with the new design/functionality, can either of you please add the QA Pass - iPhone X label? Thanks!

@LaurenWags
Copy link
Member

LaurenWags commented Jul 17, 2019

  • Verified passed on iPad 5th Gen (iOS 12.3.1) running 1.10 (19.07.16.23)
    • Verified each item under the menu opens and behaves as expected.

IMG_9E45EAEF979B-1

  • Verification PASSED on iPhone 6s+ running iOS 12.3.1 using 1.10 (19.07.16.23)
    • ensured that each item under the menu opens and behaves as expected
    • ensured the menu's differ when opening the NTP and a tab with a website loaded

IMG_9776

IMG_9775

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants