From b966744f507fbdf460c81783e86b0c9a4ded9701 Mon Sep 17 00:00:00 2001 From: Alexandru Solomon <119142018+bo1ta@users.noreply.github.com> Date: Mon, 23 Oct 2023 21:31:11 +0300 Subject: [PATCH] Fix #8286: Update "Edit bookmark" to "Edit favorite" when long pressing a favorite (#8303) --- Sources/Brave/Frontend/Browser/BrowserViewController.swift | 2 +- .../Frontend/Browser/Favorites/FavoritesViewController.swift | 2 +- .../New Tab Page/Sections/FavoritesSectionProvider.swift | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Sources/Brave/Frontend/Browser/BrowserViewController.swift b/Sources/Brave/Frontend/Browser/BrowserViewController.swift index 11ab219b04f..cd57eae1d47 100644 --- a/Sources/Brave/Frontend/Browser/BrowserViewController.swift +++ b/Sources/Brave/Frontend/Browser/BrowserViewController.swift @@ -3063,7 +3063,7 @@ extension BrowserViewController: NewTabPageDelegate { let editPopup = UIAlertController .userTextInputAlert( - title: Strings.editBookmark, + title: Strings.editFavorite, message: urlString, startingText: title, startingText2: favorite.url, placeholder2: urlString, diff --git a/Sources/Brave/Frontend/Browser/Favorites/FavoritesViewController.swift b/Sources/Brave/Frontend/Browser/Favorites/FavoritesViewController.swift index 6036007db1a..54fe0ff158f 100644 --- a/Sources/Brave/Frontend/Browser/Favorites/FavoritesViewController.swift +++ b/Sources/Brave/Frontend/Browser/Favorites/FavoritesViewController.swift @@ -359,7 +359,7 @@ extension FavoritesViewController: UICollectionViewDelegateFlowLayout { self.action(bookmark, .opened(inNewTab: true, switchingToPrivateMode: false)) }) let edit = UIAction( - title: Strings.editBookmark, + title: Strings.editFavorite, handler: UIAction.deferredActionHandler { _ in self.action(bookmark, .edited) }) diff --git a/Sources/Brave/Frontend/Browser/New Tab Page/Sections/FavoritesSectionProvider.swift b/Sources/Brave/Frontend/Browser/New Tab Page/Sections/FavoritesSectionProvider.swift index b61d180166f..add029732d8 100644 --- a/Sources/Brave/Frontend/Browser/New Tab Page/Sections/FavoritesSectionProvider.swift +++ b/Sources/Brave/Frontend/Browser/New Tab Page/Sections/FavoritesSectionProvider.swift @@ -167,7 +167,7 @@ class FavoritesSectionProvider: NSObject, NTPObservableSectionProvider { self.action(favourite, .opened(inNewTab: true, switchingToPrivateMode: false)) }) let edit = UIAction( - title: Strings.editBookmark, + title: Strings.editFavorite, handler: UIAction.deferredActionHandler { _ in self.action(favourite, .edited) })