Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update search engines (uplift to 1.28.x) #9470

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Update search engines (uplift to 1.28.x) #9470

merged 2 commits into from
Jul 22, 2021

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Jul 16, 2021 •
edited by kjozwiak
Loading

Uplift of #9397 not needed, as it was merged into 1.28 👍

Uplift of #9458
Resolves brave/brave-browser#16965

Uplift of #9486
fix brave/brave-browser#16950

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jul 16, 2021
@deeppandya deeppandya added this to the 1.28.x - Beta milestone Jul 16, 2021
@deeppandya deeppandya requested a review from a team July 16, 2021 18:25
@deeppandya deeppandya requested a review from a team as a code owner July 16, 2021 18:25
@deeppandya deeppandya self-assigned this Jul 16, 2021
@deeppandya deeppandya force-pushed the ddg_search_update_android_1.28.x branch from 33f4a9f to cf1c5ba Compare July 19, 2021 14:58
@bsclifton bsclifton removed the request for review from a team July 21, 2021 06:55
@bsclifton bsclifton mentioned this pull request Jul 21, 2021
Closed
7 tasks
@bsclifton bsclifton changed the title Update DDG SE (Uplift to 1.28.x) Update search engines (uplift to 1.28.x) Jul 21, 2021
@deeppandya @bsclifton
Update DDG Se (#9458)
59aeede 
* Update DDG Se

* Fix broken Android tests

Co-authored-by: Brian Clifton <[email protected]>
@deeppandya deeppandya force-pushed the ddg_search_update_android_1.28.x branch from dc5dd3f to 59aeede Compare July 21, 2021 14:57
@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android and removed CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jul 21, 2021
kjozwiak
kjozwiak approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.28.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #9397 (comment), #9458 (comment) & #9486 (comment).

@kjozwiak kjozwiak merged commit 27f42a6 into 1.28.x Jul 22, 2021
@kjozwiak kjozwiak deleted the ddg_search_update_android_1.28.x branch July 22, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

@simonhong simonhong

Labels
CI/skip-android Do not run CI builds for Android
Projects
None yet
Milestone
1.28.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@deeppandya @kjozwiak @simonhong @brave-browser-releases