Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable public gateway in incognito #9355

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jul 7, 2021

Resolves brave/brave-browser#16737

  • do not redirect public gateway for incognito profiles

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. new profile
  2. launch Brave
  3. set Method to resolve IPFS resources to Gateway in brave://settings/ipfs
  4. do either/both a Private Window / Guest Window
  5. load ipns://brantly.eth or ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR

@spylogsster spylogsster requested a review from yrliou July 7, 2021 15:22
@spylogsster spylogsster self-assigned this Jul 7, 2021
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spylogsster spylogsster merged commit 111f91d into master Jul 7, 2021
@spylogsster spylogsster deleted the disable-ipfs-in-incognito branch July 7, 2021 19:38
@spylogsster spylogsster added this to the 1.28.x - Nightly milestone Jul 7, 2021
@stephendonner
Copy link
Contributor

stephendonner commented Jul 8, 2021

Verified FIXED using

Brave | 1.28.64 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision | dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS | macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launched Brave
  3. set Method to resolve IPFS resources to Gateway in brave://settings/ipfs
  4. opened the following: New Private Window, Guest Window, and New Private Window with Tor
  5. loaded ipns://brantly.eth and ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR

Confirmed neither of the two URL schemes loaded in any of those 3 window types

ipns://

private window private window with tor guest window
Screen Shot 2021-07-08 at 12 01 18 PM Screen Shot 2021-07-08 at 12 01 29 PM Screen Shot 2021-07-08 at 12 01 46 PM

ipfs://

private window private window with tor guest window
Screen Shot 2021-07-08 at 11 58 11 AM Screen Shot 2021-07-08 at 11 58 30 AM Screen Shot 2021-07-08 at 11 58 19 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipns and ipfs URLs should not redirect/load over a Gateway in Private and Guest windows
4 participants