Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make brave browser set as a default browser in linux #911

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 15, 2018

With this PR, all channel except nightly can be a default browser.

Fix brave/brave-browser#1274

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

With this PR, all channel except nightly can be a default browser.
@simonhong simonhong self-assigned this Nov 15, 2018
@simonhong simonhong requested a review from darkdh November 15, 2018 07:40
@simonhong simonhong merged commit a5edaac into master Nov 15, 2018
@simonhong simonhong deleted the linux_default_browser branch November 15, 2018 23:23
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop]Cannot make Brave the default browser on Linux
3 participants