Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust minimum BAT amount for Uphold to 15 #8453

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Apr 6, 2021

Resolves brave/brave-browser#15055

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Scenario: User has less than 15 BAT

  • Given that the user has less than 15 BAT and is not connected to Uphold
  • When the user clicks the "Verify Wallet" link from either the rewards panel or the rewards page
  • Then the "login popup" should be displayed
  • And the text within the popup should contain "15 BAT"
  • And the "Login" button should redirect the user to Uphold for authorization

Scenario: User has more than 15 BAT (rewards panel)

  • Given that the user has 15 BAT or more and is not connected to Uphold
  • When the user clicks the "Verify Wallet" link from the rewards panel
  • Then a new window should be opened pointing to the rewards page and displaying the Verify Wallet modal

Scenario: User has more than 15 BAT (rewards page)

  • Given that the user has 15 BAT or more and is not connected to Uphold
  • When the user clicks the "Verify Wallet" link from the rewards page
  • Then the Verify Wallet modal should be displayed

@zenparsing zenparsing self-assigned this Apr 6, 2021
@zenparsing zenparsing requested a review from emerick April 8, 2021 17:58
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */

export const upholdMinimumBalance = 15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce Uphold minimum BAT user wallet verification requirement to 15 BAT
2 participants